You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Agam Dass (JIRA)" <de...@myfaces.apache.org> on 2009/02/20 10:37:01 UTC
[jira] Created: (TRINIDAD-1407) DateTimeConverter doesn't convert
correctly as per the expectedDataType
DateTimeConverter doesn't convert correctly as per the expectedDataType
-----------------------------------------------------------------------
Key: TRINIDAD-1407
URL: https://issues.apache.org/jira/browse/TRINIDAD-1407
Project: MyFaces Trinidad
Issue Type: Bug
Reporter: Agam Dass
Priority: Blocker
In the org.apache.myfaces.trinidadinternal.convert.DateTimeConverter#getAsObject() retrieves the date by parsing the String and then it calls DateTimeConverter.__typeConvert() to convert this type to the expected type. But in the method __typeConvert() it gets the expectedType by calling the type instead of getting the expectedType().
So it should be changed to expression.getExpectedType() instead of expression.getType()
Class : org.apache.myfaces.trinidadinternal.convert.DateTimeConverter
Method :
static Object __typeConvert(FacesContext context, Converter converter, UIComponent component,
String strValue, Object value)
Line # 123
Remove : Class<?> expectedType = expression.getType(context.getELContext());
Add : Class<?> expectedType = expression.getExpectedType();
===========================================================================
This need to be fixed in Trinidad 1.2.10.1 and then forward-port to Trinidad 1.2.11.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (TRINIDAD-1407) DateTimeConverter
doesn't convert correctly as per the expectedDataType
Posted by "Agam Dass (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675298#action_12675298 ]
agdass edited comment on TRINIDAD-1407 at 2/20/09 1:43 AM:
--------------------------------------------------------------
Change should be made to Trinidad 1.2.10.1 and then forward-port to Trinidad 1.2.11.1.
was (Author: agdass):
Should be made to Trinidad 1.2.10.1 and then forward-port to Trinidad 1.2.11.1.
> DateTimeConverter doesn't convert correctly as per the expectedDataType
> -----------------------------------------------------------------------
>
> Key: TRINIDAD-1407
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1407
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.10-core
> Reporter: Agam Dass
> Priority: Blocker
> Fix For: 1.2.10-sandbox
>
>
> In the org.apache.myfaces.trinidadinternal.convert.DateTimeConverter#getAsObject() retrieves the date by parsing the String and then it calls DateTimeConverter.__typeConvert() to convert this type to the expected type. But in the method __typeConvert() it gets the expectedType by calling the type instead of getting the expectedType().
> So it should be changed to expression.getExpectedType() instead of expression.getType()
> Class : org.apache.myfaces.trinidadinternal.convert.DateTimeConverter
> Method :
> static Object __typeConvert(FacesContext context, Converter converter, UIComponent component,
> String strValue, Object value)
> Line # 123
> Remove : Class<?> expectedType = expression.getType(context.getELContext());
> Add : Class<?> expectedType = expression.getExpectedType();
> ===========================================================================
> This need to be fixed in Trinidad 1.2.10.1 and then forward-port to Trinidad 1.2.11.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-1407) DateTimeConverter doesn't convert
correctly as per the expectedDataType
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675419#action_12675419 ]
Matthias Weßendorf commented on TRINIDAD-1407:
----------------------------------------------
I am committing this now
> DateTimeConverter doesn't convert correctly as per the expectedDataType
> -----------------------------------------------------------------------
>
> Key: TRINIDAD-1407
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1407
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.10-core
> Reporter: Agam Dass
> Assignee: Matthias Weßendorf
> Priority: Blocker
> Attachments: conversion.patch
>
>
> In the org.apache.myfaces.trinidadinternal.convert.DateTimeConverter#getAsObject() retrieves the date by parsing the String and then it calls DateTimeConverter.__typeConvert() to convert this type to the expected type. But in the method __typeConvert() it gets the expectedType by calling the type instead of getting the expectedType().
> So it should be changed to expression.getExpectedType() instead of expression.getType()
> Class : org.apache.myfaces.trinidadinternal.convert.DateTimeConverter
> Method :
> static Object __typeConvert(FacesContext context, Converter converter, UIComponent component,
> String strValue, Object value)
> Line # 123
> Remove : Class<?> expectedType = expression.getType(context.getELContext());
> Add : Class<?> expectedType = expression.getExpectedType();
> ===========================================================================
> This need to be fixed in Trinidad 1.2.10.1 and then forward-port to Trinidad 1.2.11.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (TRINIDAD-1407) DateTimeConverter doesn't convert
correctly as per the expectedDataType
Posted by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeanne Waldman reopened TRINIDAD-1407:
--------------------------------------
This latest fix didn't work either, so I'm reopening so we can look into this again.
> DateTimeConverter doesn't convert correctly as per the expectedDataType
> -----------------------------------------------------------------------
>
> Key: TRINIDAD-1407
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1407
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.10-core
> Reporter: Agam Dass
> Assignee: Matthias Weßendorf
> Priority: Blocker
> Fix For: 1.2.12-core
>
> Attachments: conversion.patch
>
>
> In the org.apache.myfaces.trinidadinternal.convert.DateTimeConverter#getAsObject() retrieves the date by parsing the String and then it calls DateTimeConverter.__typeConvert() to convert this type to the expected type. But in the method __typeConvert() it gets the expectedType by calling the type instead of getting the expectedType().
> So it should be changed to expression.getExpectedType() instead of expression.getType()
> Class : org.apache.myfaces.trinidadinternal.convert.DateTimeConverter
> Method :
> static Object __typeConvert(FacesContext context, Converter converter, UIComponent component,
> String strValue, Object value)
> Line # 123
> Remove : Class<?> expectedType = expression.getType(context.getELContext());
> Add : Class<?> expectedType = expression.getExpectedType();
> ===========================================================================
> This need to be fixed in Trinidad 1.2.10.1 and then forward-port to Trinidad 1.2.11.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1407) DateTimeConverter doesn't convert
correctly as per the expectedDataType
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated TRINIDAD-1407:
-----------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
another try to finally fix this ... :)
> DateTimeConverter doesn't convert correctly as per the expectedDataType
> -----------------------------------------------------------------------
>
> Key: TRINIDAD-1407
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1407
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.10-core
> Reporter: Agam Dass
> Assignee: Matthias Weßendorf
> Priority: Blocker
> Fix For: 1.2.12-core
>
> Attachments: date_conv.patch
>
>
> In the org.apache.myfaces.trinidadinternal.convert.DateTimeConverter#getAsObject() retrieves the date by parsing the String and then it calls DateTimeConverter.__typeConvert() to convert this type to the expected type. But in the method __typeConvert() it gets the expectedType by calling the type instead of getting the expectedType().
> So it should be changed to expression.getExpectedType() instead of expression.getType()
> Class : org.apache.myfaces.trinidadinternal.convert.DateTimeConverter
> Method :
> static Object __typeConvert(FacesContext context, Converter converter, UIComponent component,
> String strValue, Object value)
> Line # 123
> Remove : Class<?> expectedType = expression.getType(context.getELContext());
> Add : Class<?> expectedType = expression.getExpectedType();
> ===========================================================================
> This need to be fixed in Trinidad 1.2.10.1 and then forward-port to Trinidad 1.2.11.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TRINIDAD-1407) DateTimeConverter doesn't convert
correctly as per the expectedDataType
Posted by "Gabrielle Crawford (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gabrielle Crawford resolved TRINIDAD-1407.
------------------------------------------
Resolution: Fixed
Sometimes the valueExpression's expectedType is just object, so use type instead.
> DateTimeConverter doesn't convert correctly as per the expectedDataType
> -----------------------------------------------------------------------
>
> Key: TRINIDAD-1407
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1407
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.10-core
> Reporter: Agam Dass
> Assignee: Matthias Weßendorf
> Priority: Blocker
> Fix For: 1.2.12-core
>
> Attachments: conversion.patch
>
>
> In the org.apache.myfaces.trinidadinternal.convert.DateTimeConverter#getAsObject() retrieves the date by parsing the String and then it calls DateTimeConverter.__typeConvert() to convert this type to the expected type. But in the method __typeConvert() it gets the expectedType by calling the type instead of getting the expectedType().
> So it should be changed to expression.getExpectedType() instead of expression.getType()
> Class : org.apache.myfaces.trinidadinternal.convert.DateTimeConverter
> Method :
> static Object __typeConvert(FacesContext context, Converter converter, UIComponent component,
> String strValue, Object value)
> Line # 123
> Remove : Class<?> expectedType = expression.getType(context.getELContext());
> Add : Class<?> expectedType = expression.getExpectedType();
> ===========================================================================
> This need to be fixed in Trinidad 1.2.10.1 and then forward-port to Trinidad 1.2.11.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1407) DateTimeConverter doesn't convert
correctly as per the expectedDataType
Posted by "Agam Dass (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Agam Dass updated TRINIDAD-1407:
--------------------------------
Status: Patch Available (was: Open)
> DateTimeConverter doesn't convert correctly as per the expectedDataType
> -----------------------------------------------------------------------
>
> Key: TRINIDAD-1407
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1407
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.10-core
> Reporter: Agam Dass
> Priority: Blocker
>
> In the org.apache.myfaces.trinidadinternal.convert.DateTimeConverter#getAsObject() retrieves the date by parsing the String and then it calls DateTimeConverter.__typeConvert() to convert this type to the expected type. But in the method __typeConvert() it gets the expectedType by calling the type instead of getting the expectedType().
> So it should be changed to expression.getExpectedType() instead of expression.getType()
> Class : org.apache.myfaces.trinidadinternal.convert.DateTimeConverter
> Method :
> static Object __typeConvert(FacesContext context, Converter converter, UIComponent component,
> String strValue, Object value)
> Line # 123
> Remove : Class<?> expectedType = expression.getType(context.getELContext());
> Add : Class<?> expectedType = expression.getExpectedType();
> ===========================================================================
> This need to be fixed in Trinidad 1.2.10.1 and then forward-port to Trinidad 1.2.11.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1407) DateTimeConverter doesn't convert
correctly as per the expectedDataType
Posted by "Agam Dass (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Agam Dass updated TRINIDAD-1407:
--------------------------------
Status: Patch Available (was: Reopened)
> DateTimeConverter doesn't convert correctly as per the expectedDataType
> -----------------------------------------------------------------------
>
> Key: TRINIDAD-1407
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1407
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.10-core
> Reporter: Agam Dass
> Assignee: Matthias Weßendorf
> Priority: Blocker
> Fix For: 1.2.12-core
>
> Attachments: conversion.patch
>
>
> In the org.apache.myfaces.trinidadinternal.convert.DateTimeConverter#getAsObject() retrieves the date by parsing the String and then it calls DateTimeConverter.__typeConvert() to convert this type to the expected type. But in the method __typeConvert() it gets the expectedType by calling the type instead of getting the expectedType().
> So it should be changed to expression.getExpectedType() instead of expression.getType()
> Class : org.apache.myfaces.trinidadinternal.convert.DateTimeConverter
> Method :
> static Object __typeConvert(FacesContext context, Converter converter, UIComponent component,
> String strValue, Object value)
> Line # 123
> Remove : Class<?> expectedType = expression.getType(context.getELContext());
> Add : Class<?> expectedType = expression.getExpectedType();
> ===========================================================================
> This need to be fixed in Trinidad 1.2.10.1 and then forward-port to Trinidad 1.2.11.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1407) DateTimeConverter doesn't convert
correctly as per the expectedDataType
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated TRINIDAD-1407:
-----------------------------------------
Resolution: Fixed
Fix Version/s: 1.2.12-core
Status: Resolved (was: Patch Available)
> DateTimeConverter doesn't convert correctly as per the expectedDataType
> -----------------------------------------------------------------------
>
> Key: TRINIDAD-1407
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1407
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.10-core
> Reporter: Agam Dass
> Assignee: Matthias Weßendorf
> Priority: Blocker
> Fix For: 1.2.12-core
>
> Attachments: conversion.patch
>
>
> In the org.apache.myfaces.trinidadinternal.convert.DateTimeConverter#getAsObject() retrieves the date by parsing the String and then it calls DateTimeConverter.__typeConvert() to convert this type to the expected type. But in the method __typeConvert() it gets the expectedType by calling the type instead of getting the expectedType().
> So it should be changed to expression.getExpectedType() instead of expression.getType()
> Class : org.apache.myfaces.trinidadinternal.convert.DateTimeConverter
> Method :
> static Object __typeConvert(FacesContext context, Converter converter, UIComponent component,
> String strValue, Object value)
> Line # 123
> Remove : Class<?> expectedType = expression.getType(context.getELContext());
> Add : Class<?> expectedType = expression.getExpectedType();
> ===========================================================================
> This need to be fixed in Trinidad 1.2.10.1 and then forward-port to Trinidad 1.2.11.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (TRINIDAD-1407) DateTimeConverter doesn't convert
correctly as per the expectedDataType
Posted by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeanne Waldman reopened TRINIDAD-1407:
--------------------------------------
I need to revert these changes temporarily since they are causing SRG test failures.
> DateTimeConverter doesn't convert correctly as per the expectedDataType
> -----------------------------------------------------------------------
>
> Key: TRINIDAD-1407
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1407
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.10-core
> Reporter: Agam Dass
> Assignee: Matthias Weßendorf
> Priority: Blocker
> Fix For: 1.2.12-core
>
> Attachments: conversion.patch
>
>
> In the org.apache.myfaces.trinidadinternal.convert.DateTimeConverter#getAsObject() retrieves the date by parsing the String and then it calls DateTimeConverter.__typeConvert() to convert this type to the expected type. But in the method __typeConvert() it gets the expectedType by calling the type instead of getting the expectedType().
> So it should be changed to expression.getExpectedType() instead of expression.getType()
> Class : org.apache.myfaces.trinidadinternal.convert.DateTimeConverter
> Method :
> static Object __typeConvert(FacesContext context, Converter converter, UIComponent component,
> String strValue, Object value)
> Line # 123
> Remove : Class<?> expectedType = expression.getType(context.getELContext());
> Add : Class<?> expectedType = expression.getExpectedType();
> ===========================================================================
> This need to be fixed in Trinidad 1.2.10.1 and then forward-port to Trinidad 1.2.11.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.