You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/04 02:32:20 UTC
[GitHub] [apisix] dickens7 opened a new pull request #5999: fix: upgrade dns-client to 5.2.3
dickens7 opened a new pull request #5999:
URL: https://github.com/apache/apisix/pull/5999
### What this PR does / why we need it:
#5855
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] dickens7 commented on a change in pull request #5999: fix: upgrade dns-client to 5.2.3
Posted by GitBox <gi...@apache.org>.
dickens7 commented on a change in pull request #5999:
URL: https://github.com/apache/apisix/pull/5999#discussion_r777900651
##########
File path: rockspec/apisix-master-0.rockspec
##########
@@ -32,7 +32,7 @@ description = {
dependencies = {
"lua-resty-ctxdump = 0.1-0",
- "lua-resty-dns-client = 5.2.0",
+ "lua-resty-dns-client = 5.2.3",
Review comment:
Well, let me first look at the compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5999: fix: resolve unambiguous fully-qualified domain name(FQDN), i.e. ended in a dot
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5999:
URL: https://github.com/apache/apisix/pull/5999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5999: fix: upgrade dns-client to 5.2.3
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5999:
URL: https://github.com/apache/apisix/pull/5999#discussion_r777844345
##########
File path: rockspec/apisix-master-0.rockspec
##########
@@ -32,7 +32,7 @@ description = {
dependencies = {
"lua-resty-ctxdump = 0.1-0",
- "lua-resty-dns-client = 5.2.0",
+ "lua-resty-dns-client = 5.2.3",
Review comment:
Maybe we can use the latest release directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org