You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "andreahlert (via GitHub)" <gi...@apache.org> on 2026/02/08 11:04:40 UTC

[PR] Add run type legend tooltip to grid view [airflow]

andreahlert opened a new pull request, #61632:
URL: https://github.com/apache/airflow/pull/61632

   Closes #28737.
   
   This adds a small info icon (ℹ) next to the existing keyboard shortcut icon in the grid view. On hover, it displays a tooltip showing each DAG run type with its corresponding icon:
   
   - Scheduled
   - Manual
   - Backfill
   - Asset Triggered
   
   The previous attempt (#51736) was closed due to performance issues with Chakra tooltips on large grids and bad UX with truncated markdown notes. This implementation keeps things simple by reusing the existing `Tooltip` component (same as the keyboard shortcut tooltip) and the `RunTypeIcon` component already used throughout the grid.
   
   Note indicators were left out of scope since the grid API responses (`GridRunsResponse`, `LightGridTaskInstanceSummary`) don't include note fields.
   
   **Changes:**
   - New `GridLegend` component in `layouts/Details/Grid/GridLegend.tsx`
   - Added `GridLegend` to `PanelButtons.tsx` (grid-only section)
   - Added `legend` translation key to `dag.json`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add run type legend tooltip to grid view [airflow]

Posted by "andreahlert (via GitHub)" <gi...@apache.org>.
andreahlert commented on code in PR #61632:
URL: https://github.com/apache/airflow/pull/61632#discussion_r2873901555


##########
airflow-core/src/airflow/ui/src/layouts/Details/Grid/GridLegend.tsx:
##########
@@ -0,0 +1,51 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { Box, Flex, Text } from "@chakra-ui/react";
+import { useTranslation } from "react-i18next";
+import { LuInfo } from "react-icons/lu";
+
+import type { DAGRunResponse } from "openapi/requests/types.gen";
+import { RunTypeIcon } from "src/components/RunTypeIcon";
+import { Tooltip } from "src/components/ui";
+
+const runTypes: Array<DAGRunResponse["run_type"]> = ["scheduled", "manual", "backfill", "asset_triggered"];
+
+export const RunTypeLegend = () => {

Review Comment:
   Thanks. Completely forgot. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add run type legend tooltip to grid view [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #61632:
URL: https://github.com/apache/airflow/pull/61632#discussion_r2795230997


##########
airflow-core/src/airflow/ui/src/layouts/Details/Grid/GridLegend.tsx:
##########
@@ -0,0 +1,51 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { Box, Flex, Text } from "@chakra-ui/react";
+import { useTranslation } from "react-i18next";
+import { LuInfo } from "react-icons/lu";
+
+import type { DAGRunResponse } from "openapi/requests/types.gen";
+import { RunTypeIcon } from "src/components/RunTypeIcon";
+import { Tooltip } from "src/components/ui";
+
+const runTypes: Array<DAGRunResponse["run_type"]> = ["scheduled", "manual", "backfill", "asset_triggered"];
+
+export const GridLegend = () => {
+  const { t: translate } = useTranslation("common");
+
+  return (
+    <Tooltip
+      content={
+        <Box>

Review Comment:
   here add "Run Type Legend" text 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add run type legend tooltip to grid view [airflow]

Posted by "andreahlert (via GitHub)" <gi...@apache.org>.
andreahlert closed pull request #61632: Add run type legend tooltip to grid view
URL: https://github.com/apache/airflow/pull/61632


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add run type legend tooltip to grid view [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #61632:
URL: https://github.com/apache/airflow/pull/61632#discussion_r2873467189


##########
airflow-core/src/airflow/ui/src/layouts/Details/Grid/GridLegend.tsx:
##########
@@ -0,0 +1,51 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { Box, Flex, Text } from "@chakra-ui/react";
+import { useTranslation } from "react-i18next";
+import { LuInfo } from "react-icons/lu";
+
+import type { DAGRunResponse } from "openapi/requests/types.gen";
+import { RunTypeIcon } from "src/components/RunTypeIcon";
+import { Tooltip } from "src/components/ui";
+
+const runTypes: Array<DAGRunResponse["run_type"]> = ["scheduled", "manual", "backfill", "asset_triggered"];
+
+export const RunTypeLegend = () => {

Review Comment:
   The static and react unit test CI failures are from the code. 
   
   For instance, this component should be the same name as its file.
   ```suggestion
   export const GridLegend = () => {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add run type legend tooltip to grid view [airflow]

Posted by "andreahlert (via GitHub)" <gi...@apache.org>.
andreahlert closed pull request #61632: Add run type legend tooltip to grid view
URL: https://github.com/apache/airflow/pull/61632


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add run type legend tooltip to grid view [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #61632:
URL: https://github.com/apache/airflow/pull/61632#discussion_r2795228938


##########
airflow-core/src/airflow/ui/public/i18n/locales/en/dag.json:
##########
@@ -45,7 +45,8 @@
     "buttons": {
       "resetToLatest": "Reset to latest",
       "toggleGroup": "Toggle group"
-    }
+    },
+    "legend": "Run Type Legend"

Review Comment:
   Your not using it, it should be above the run types description



##########
airflow-core/src/airflow/ui/src/layouts/Details/Grid/GridLegend.tsx:
##########
@@ -0,0 +1,51 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { Box, Flex, Text } from "@chakra-ui/react";
+import { useTranslation } from "react-i18next";
+import { LuInfo } from "react-icons/lu";
+
+import type { DAGRunResponse } from "openapi/requests/types.gen";
+import { RunTypeIcon } from "src/components/RunTypeIcon";
+import { Tooltip } from "src/components/ui";
+
+const runTypes: Array<DAGRunResponse["run_type"]> = ["scheduled", "manual", "backfill", "asset_triggered"];
+
+export const GridLegend = () => {
+  const { t: translate } = useTranslation("common");
+
+  return (
+    <Tooltip
+      content={
+        <Box>

Review Comment:
   here add "Run Type Legend"



##########
airflow-core/src/airflow/ui/src/layouts/Details/Grid/GridLegend.tsx:
##########
@@ -0,0 +1,51 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { Box, Flex, Text } from "@chakra-ui/react";
+import { useTranslation } from "react-i18next";
+import { LuInfo } from "react-icons/lu";
+
+import type { DAGRunResponse } from "openapi/requests/types.gen";
+import { RunTypeIcon } from "src/components/RunTypeIcon";
+import { Tooltip } from "src/components/ui";
+
+const runTypes: Array<DAGRunResponse["run_type"]> = ["scheduled", "manual", "backfill", "asset_triggered"];
+
+export const GridLegend = () => {

Review Comment:
   ```suggestion
   export const RunTypeLegend = () => {
   ```



##########
airflow-core/src/airflow/ui/public/i18n/locales/en/dag.json:
##########
@@ -45,7 +45,8 @@
     "buttons": {
       "resetToLatest": "Reset to latest",
       "toggleGroup": "Toggle group"
-    }
+    },
+    "legend": "Run Type Legend"

Review Comment:
   Nit:
   
   ```suggestion
       "runTypeLegend": "Run Type Legend"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add run type legend tooltip to grid view [airflow]

Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #61632:
URL: https://github.com/apache/airflow/pull/61632#issuecomment-3867097870

   Could help attach screenshot for your changes, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add run type legend tooltip to grid view [airflow]

Posted by "andreahlert (via GitHub)" <gi...@apache.org>.
andreahlert commented on code in PR #61632:
URL: https://github.com/apache/airflow/pull/61632#discussion_r2839231727


##########
airflow-core/src/airflow/ui/src/layouts/Details/Grid/GridLegend.tsx:
##########
@@ -0,0 +1,51 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { Box, Flex, Text } from "@chakra-ui/react";
+import { useTranslation } from "react-i18next";
+import { LuInfo } from "react-icons/lu";
+
+import type { DAGRunResponse } from "openapi/requests/types.gen";
+import { RunTypeIcon } from "src/components/RunTypeIcon";
+import { Tooltip } from "src/components/ui";
+
+const runTypes: Array<DAGRunResponse["run_type"]> = ["scheduled", "manual", "backfill", "asset_triggered"];
+
+export const GridLegend = () => {
+  const { t: translate } = useTranslation("common");
+
+  return (
+    <Tooltip
+      content={
+        <Box>

Review Comment:
   Resolved in 87cfda7



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add run type legend tooltip to grid view [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #61632:
URL: https://github.com/apache/airflow/pull/61632#issuecomment-4006113989

   I'm not sure why the PR was closed, here is a followup PR that addresses the small nits so it can be merged https://github.com/apache/airflow/pull/62946


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add run type legend tooltip to grid view [airflow]

Posted by "andreahlert (via GitHub)" <gi...@apache.org>.
andreahlert commented on PR #61632:
URL: https://github.com/apache/airflow/pull/61632#issuecomment-4006596177

   @pierrejeambrun I'm not sure what happened to. I was reviewing multiple PRs, this one was closed by accident i think. Reopening. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add run type legend tooltip to grid view [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #61632:
URL: https://github.com/apache/airflow/pull/61632#issuecomment-3915828737

   Let me know when this is ready for another review. (on comment still needs to be addressed and CI is not happy, but that doens't seem related though, just pushing a new commit should restart it)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add run type legend tooltip to grid view [airflow]

Posted by "andreahlert (via GitHub)" <gi...@apache.org>.
andreahlert commented on PR #61632:
URL: https://github.com/apache/airflow/pull/61632#issuecomment-3943008911

   > Let me know when this is ready for another review. (one comment still needs to be addressed and CI is not happy, but that doens't seem related though, just pushing a new commit should restart it)
   
   None of the failing CI jobs are related to my changes (React UI: Logs.test.tsx; constraints: Python). Happy to fix if you guys prefer, but the PR itself doesn’t touch those areas.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add run type legend tooltip to grid view [airflow]

Posted by "andreahlert (via GitHub)" <gi...@apache.org>.
andreahlert commented on PR #61632:
URL: https://github.com/apache/airflow/pull/61632#issuecomment-4006605802

   @pierrejeambrun I'm not sure what happened to. I was reviewing multiple PRs, this one was closed by accident i think. But we can keep your new one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add run type legend tooltip to grid view [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #61632:
URL: https://github.com/apache/airflow/pull/61632#issuecomment-3886791577

   Updated the PR description. Its part of https://github.com/apache/airflow/issues/28737. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org