You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/07 07:19:24 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #35414: [SPARK-38125][BUILD][SQL] Use static factory methods instead of the deprecated Integer constructors
dongjoon-hyun opened a new pull request #35414:
URL: https://github.com/apache/spark/pull/35414
### What changes were proposed in this pull request?
This PR aims to use static factor methods instead of the deprecated `Integer` constructors and add Java/Scala linter rules to enforce new styles.
### Why are the changes needed?
`Integer` constructors are deprecated in Java 9.
- https://docs.oracle.com/javase/9/docs/api/java/lang/Integer.html#Integer-int-
- https://docs.oracle.com/javase/9/docs/api/java/lang/Integer.html#Integer-java.lang.String-
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs with the newly added Scalastyle and Java Checkstyle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35414: [SPARK-38125][BUILD][SQL] Use static factory methods instead of the deprecated `Byte/Short/Integer/Long` constructors
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35414:
URL: https://github.com/apache/spark/pull/35414#issuecomment-1035845064
Thank you @srowen .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #35414: [SPARK-38125][BUILD][SQL] Use static factory methods instead of the deprecated `Byte/Short/Integer/Long` constructors
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35414:
URL: https://github.com/apache/spark/pull/35414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35414: [SPARK-38125][BUILD][SQL] Use static factory methods instead of the deprecated `Integer` constructors
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35414:
URL: https://github.com/apache/spark/pull/35414#issuecomment-1031756799
Thank you, @srowen . Let me check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35414: [SPARK-38125][BUILD][SQL] Use static factory methods instead of the deprecated `Integer` constructors
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35414:
URL: https://github.com/apache/spark/pull/35414#issuecomment-1035587105
Hi, @srowen . The PR is updated to handle `Byte/Short/Integer/Long` together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35414: [SPARK-38125][BUILD][SQL] Use static factory methods instead of the deprecated `Byte/Short/Integer/Long` constructors
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35414:
URL: https://github.com/apache/spark/pull/35414#issuecomment-1035844985
Linter job passed and only one irrelevant flaky test failed.
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org