You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "James Xu (JIRA)" <ji...@apache.org> on 2017/06/15 02:38:00 UTC

[jira] [Commented] (BEAM-2444) DSL SQL: Use standard java exceptions instead of custom ones

    [ https://issues.apache.org/jira/browse/BEAM-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049929#comment-16049929 ] 

James Xu commented on BEAM-2444:
--------------------------------

I will take this one.

> DSL SQL: Use standard java exceptions instead of custom ones
> ------------------------------------------------------------
>
>                 Key: BEAM-2444
>                 URL: https://issues.apache.org/jira/browse/BEAM-2444
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Luke Cwik
>            Assignee: Xu Mingmin
>            Priority: Minor
>              Labels: dsl_sql_merge
>
> Remove the Beam SQL exception type and use the standard Java one with the same purpose.
> Beam SQL exception types:
> {code}
> org.apache.beam.dsls.sql.exception.BeamSqlUnsupportedException
> org.apache.beam.dsls.sql.schema.UnsupportedDataTypeException
> org.apache.beam.dsls.sql.exception.InvalidFieldException
> org.apache.beam.dsls.sql.exception.BeamInvalidOperatorException
> {code}
> Suggested alternatives depending on the context of where/why exception is being thrown:
> {code}
> java.lang.UnsupportedOperationException
> java.lang.IllegalArgumentException
> java.lang.IllegalStateException
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)