You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/09 02:48:15 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4806:
Refactor segments admin rest APIs
codecov-io edited a comment on issue #4806: Refactor segments admin rest APIs
URL: https://github.com/apache/incubator-pinot/pull/4806#issuecomment-552058498
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4806?src=pr&el=h1) Report
> Merging [#4806](https://codecov.io/gh/apache/incubator-pinot/pull/4806?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/c9f465aeea6f2daec6a64338ecfb5a9ee5c423f4?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `21.95%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4806?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4806 +/- ##
============================================
- Coverage 57.56% 57.27% -0.29%
Complexity 4 4
============================================
Files 1212 1212
Lines 65600 65478 -122
Branches 9557 9531 -26
============================================
- Hits 37760 37505 -255
- Misses 24964 25139 +175
+ Partials 2876 2834 -42
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4806?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../controller/helix/ControllerRequestURLBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4806/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9Db250cm9sbGVyUmVxdWVzdFVSTEJ1aWxkZXIuamF2YQ==) | `71.05% <ø> (-4.59%)` | `0 <0> (ø)` | |
| [...ntroller/helix/core/PinotHelixResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4806/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1Bpbm90SGVsaXhSZXNvdXJjZU1hbmFnZXIuamF2YQ==) | `63.54% <ø> (+1.92%)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/pinot/controller/api/resources/Constants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4806/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL0NvbnN0YW50cy5qYXZh) | `21.42% <0%> (-7.15%)` | `0 <0> (ø)` | |
| [...ller/api/resources/PinotSchemaRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4806/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90U2NoZW1hUmVzdGxldFJlc291cmNlLmphdmE=) | `39.18% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...er/api/resources/LLCSegmentCompletionHandlers.java](https://codecov.io/gh/apache/incubator-pinot/pull/4806/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL0xMQ1NlZ21lbnRDb21wbGV0aW9uSGFuZGxlcnMuamF2YQ==) | `32.24% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ces/PinotSegmentUploadDownloadRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4806/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90U2VnbWVudFVwbG9hZERvd25sb2FkUmVzdGxldFJlc291cmNlLmphdmE=) | `66.66% <100%> (ø)` | `0 <0> (?)` | |
| [...ler/api/resources/PinotSegmentRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4806/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90U2VnbWVudFJlc3RsZXRSZXNvdXJjZS5qYXZh) | `23.02% <21.36%> (-6.98%)` | `0 <0> (ø)` | |
| [...e/pinot/common/config/TypedMapChildKeyHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4806/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1R5cGVkTWFwQ2hpbGRLZXlIYW5kbGVyLmphdmE=) | `34.78% <0%> (-52.18%)` | `0% <0%> (ø)` | |
| [...ment/virtualcolumn/DocIdVirtualColumnProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4806/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vRG9jSWRWaXJ0dWFsQ29sdW1uUHJvdmlkZXIuamF2YQ==) | `45% <0%> (-27.5%)` | `0% <0%> (ø)` | |
| [...nt/virtualcolumn/IntSingleValueDataFileReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4806/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vSW50U2luZ2xlVmFsdWVEYXRhRmlsZVJlYWRlci5qYXZh) | `55.55% <0%> (-22.23%)` | `0% <0%> (ø)` | |
| ... and [50 more](https://codecov.io/gh/apache/incubator-pinot/pull/4806/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4806?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4806?src=pr&el=footer). Last update [c9f465a...f77bea6](https://codecov.io/gh/apache/incubator-pinot/pull/4806?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org