[GitHub] [hadoop] goiri commented on a diff in pull request #5606: YARN-9049. Add application submit data to state store.

["goiri (via GitHub)" <gi...@apache.org>]

goiri commented on code in PR #5606:
URL: https://github.com/apache/hadoop/pull/5606#discussion_r1181724019


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/FederationApplicationHomeSubClusterStore.java:
##########
@@ -117,5 +117,4 @@ GetApplicationsHomeSubClusterResponse getApplicationsHomeSubCluster(
    */
   DeleteApplicationHomeSubClusterResponse deleteApplicationHomeSubCluster(
       DeleteApplicationHomeSubClusterRequest request) throws YarnException;
-

Review Comment:
   Let's avoid this change.



##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/ApplicationHomeSubCluster.java:
##########
@@ -160,7 +182,8 @@ public String toString() {
         .append("ApplicationId: ").append(getApplicationId()).append(", ")
         .append("HomeSubCluster: ").append(getHomeSubCluster()).append(", ")
         .append("CreateTime: ").append(getCreateTime()).append(", ")
-        .append("]");
+        .append("ApplicationSubmissionContext: ").append(getApplicationSubmissionContext())
+        .append(", ").append("]");

Review Comment:
   A little weird we have a comma at the end.
   It was there before but is that intended?



##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/ApplicationHomeSubCluster.java:
##########
@@ -160,7 +182,8 @@ public String toString() {
         .append("ApplicationId: ").append(getApplicationId()).append(", ")
         .append("HomeSubCluster: ").append(getHomeSubCluster()).append(", ")
         .append("CreateTime: ").append(getCreateTime()).append(", ")
-        .append("]");
+        .append("ApplicationSubmissionContext: ").append(getApplicationSubmissionContext())

Review Comment:
   No specific unit tests?



##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/ApplicationHomeSubCluster.java:
##########
@@ -150,7 +171,8 @@ public int hashCode() {
     return new HashCodeBuilder().
         append(this.getApplicationId()).
         append(this.getHomeSubCluster()).
-        append(this.getCreateTime()).toHashCode();
+        append(this.getCreateTime()).
+        append(this.getApplicationSubmissionContext()).toHashCode();

Review Comment:
   Put the `toHashCode()` in the next line to avoid changes in future changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org