You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by si...@apache.org on 2018/08/17 01:42:17 UTC

[bookkeeper] branch master updated: Typo in bookie request processor read handling

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new 987f804  Typo in bookie request processor read handling
987f804 is described below

commit 987f8046d9f253354c512bd2aa32307ff9ed1019
Author: Ivan Kelly <iv...@apache.org>
AuthorDate: Thu Aug 16 18:42:10 2018 -0700

    Typo in bookie request processor read handling
    
    The response in the case of overload should take the ledgerId and
    entryId from the read request.
    
    Author: Ivan Kelly <iv...@apache.org>
    
    Reviewers: Enrico Olivelli <eo...@gmail.com>, Sijie Guo <si...@apache.org>
    
    This closes #1590 from ivankelly/request-processor-typo
---
 .../main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java
index becfe68..aa9e048 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java
@@ -621,8 +621,8 @@ public class BookieRequestProcessor implements RequestProcessor {
                               r.getReadRequest().getLedgerId(), r.getReadRequest().getEntryId());
                 }
                 BookkeeperProtocol.ReadResponse.Builder readResponse = BookkeeperProtocol.ReadResponse.newBuilder()
-                    .setLedgerId(r.getAddRequest().getLedgerId())
-                    .setEntryId(r.getAddRequest().getEntryId())
+                    .setLedgerId(r.getReadRequest().getLedgerId())
+                    .setEntryId(r.getReadRequest().getEntryId())
                     .setStatus(BookkeeperProtocol.StatusCode.ETOOMANYREQUESTS);
                 BookkeeperProtocol.Response.Builder response = BookkeeperProtocol.Response.newBuilder()
                     .setHeader(read.getHeader())