You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/07/04 02:44:00 UTC
Re: Review Request 59988: Added a new protobuf message `MapMessage`
for protobuf tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59988/
-----------------------------------------------------------
(Updated July 4, 2017, 10:44 a.m.)
Review request for mesos, Anand Mazumdar and Zhitao Li.
Changes
-------
Rebased.
Bugs: MESOS-7656
https://issues.apache.org/jira/browse/MESOS-7656
Repository: mesos
Description
-------
Added a new protobuf message `MapMessage` for protobuf tests.
Diffs (updated)
-----
3rdparty/stout/tests/protobuf_tests.proto d16726aa8060aea2b830040b20dbdd467c801483
Diff: https://reviews.apache.org/r/59988/diff/4/
Changes: https://reviews.apache.org/r/59988/diff/3-4/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 59988: Added a new protobuf message `MapMessage`
for protobuf tests.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59988/#review186036
-----------------------------------------------------------
3rdparty/stout/tests/protobuf_tests.proto
Lines 102 (patched)
<https://reviews.apache.org/r/59988/#comment262411>
Please add tests for integral-typed keys.
- Chun-Hung Hsiao
On July 4, 2017, 2:44 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59988/
> -----------------------------------------------------------
>
> (Updated July 4, 2017, 2:44 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Zhitao Li.
>
>
> Bugs: MESOS-7656
> https://issues.apache.org/jira/browse/MESOS-7656
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new protobuf message `MapMessage` for protobuf tests.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/protobuf_tests.proto d16726aa8060aea2b830040b20dbdd467c801483
>
>
> Diff: https://reviews.apache.org/r/59988/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 59988: Added a new protobuf message `MapMessage`
for protobuf tests.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59988/
-----------------------------------------------------------
(Updated Dec. 19, 2017, 9:52 p.m.)
Review request for mesos, Anand Mazumdar and Zhitao Li.
Changes
-------
Addressed review comments.
Bugs: MESOS-7656
https://issues.apache.org/jira/browse/MESOS-7656
Repository: mesos
Description
-------
Added a new protobuf message `MapMessage` for protobuf tests.
Diffs (updated)
-----
3rdparty/stout/tests/protobuf_tests.proto cf8aadc7c003b3165421edb5ff2e71b6abf526f4
Diff: https://reviews.apache.org/r/59988/diff/5/
Changes: https://reviews.apache.org/r/59988/diff/4-5/
Testing
-------
Thanks,
Qian Zhang