You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "mustafasrepo (via GitHub)" <gi...@apache.org> on 2023/04/17 08:43:21 UTC

[GitHub] [arrow-datafusion] mustafasrepo commented on pull request #6003: Row accumulator support update Scalar values

mustafasrepo commented on PR #6003:
URL: https://github.com/apache/arrow-datafusion/pull/6003#issuecomment-1510941192

   I had a comment for refactoring `col_to_scalar` function. It simplifies the code and removes duplication. Is there a specific reason for not doing so? Maybe I misunderstood what `col_to_scalar` does. Without this change we may have diverging versions of similar code in `row_hash.rs` and `scalar.rs`. One may change one of them, and corresponding change may be missing in other file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org