You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/28 10:02:03 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request, #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
weizhouapache opened a new pull request, #7029:
URL: https://github.com/apache/cloudstack/pull/7029
### Description
main changes of this PR
- Introduce a new state Expunged which is final vm state (currently the final vm state is Expunging)
- Enable expunge a vm in Expunging state (current the action is disabled)
- Update vm state to Expunged if succeed to expunge a VM
- Update vm state to Error if fail to expunge a VM
- Add Expunged but not removed VMs to VM cleanup task.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1368091334
<b>Trillian test result (tid-5708)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39310 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7029-t5708-xenserver-71.zip
Smoke tests completed. 106 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1367827636
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1369689280
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7029)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7029&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7029&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7029&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7029&metric=new_coverage&view=list) [13.4% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7029&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7029&metric=new_duplicated_lines_density&view=list) [2.7% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7029&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #7029: [Draft] vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache closed pull request #7029: [Draft] vm: add Expunged as final VM state and enable expunge VMs in Expunging state
URL: https://github.com/apache/cloudstack/pull/7029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1367953848
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7029)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7029&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7029&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7029&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7029&metric=new_coverage&view=list) [13.3% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7029&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7029&metric=new_duplicated_lines_density&view=list) [2.6% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7029&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1367827806
@weizhouapache a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1379958244
small fix: https://github.com/apache/cloudstack/pull/7086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7029: [Draft] vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1406294577
@weizhouapache should this be closed as the simpler fix is merged now? https://github.com/apache/cloudstack/pull/7086/files ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1367948913
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1381488137
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7029)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7029&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7029&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7029&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7029&metric=new_coverage&view=list) [13.4% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7029&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7029&metric=new_duplicated_lines_density&view=list) [2.7% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7029&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1367802603
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1366567358
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7029)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7029&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7029&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7029&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7029&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7029&metric=new_coverage&view=list) [10.3% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7029&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7029&metric=new_duplicated_lines_density&view=list) [7.7% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7029&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1369614039
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1367823423
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1366603454
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7029?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7029](https://codecov.io/gh/apache/cloudstack/pull/7029?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3815b9c) into [main](https://codecov.io/gh/apache/cloudstack/commit/ca7e1ac1abbe78513bfdd57b990d58e018f8d65d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca7e1ac) will **decrease** coverage by `0.00%`.
> The diff coverage is `4.91%`.
```diff
@@ Coverage Diff @@
## main #7029 +/- ##
============================================
- Coverage 11.31% 11.31% -0.01%
+ Complexity 7334 7332 -2
============================================
Files 2494 2494
Lines 246787 246797 +10
Branches 38533 38537 +4
============================================
- Hits 27933 27929 -4
- Misses 215255 215270 +15
+ Partials 3599 3598 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/java/com/cloud/vm/VirtualMachineManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9jb20vY2xvdWQvdm0vVmlydHVhbE1hY2hpbmVNYW5hZ2VySW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...tack/engine/orchestration/NetworkOrchestrator.java](https://codecov.io/gh/apache/cloudstack/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svZW5naW5lL29yY2hlc3RyYXRpb24vTmV0d29ya09yY2hlc3RyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ain/java/com/cloud/vm/dao/ConsoleProxyDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC92bS9kYW8vQ29uc29sZVByb3h5RGFvSW1wbC5qYXZh) | `0.69% <0.00%> (ø)` | |
| [...ain/java/com/cloud/vm/dao/DomainRouterDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC92bS9kYW8vRG9tYWluUm91dGVyRGFvSW1wbC5qYXZh) | `33.77% <0.00%> (ø)` | |
| [...va/com/cloud/vm/dao/SecondaryStorageVmDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC92bS9kYW8vU2Vjb25kYXJ5U3RvcmFnZVZtRGFvSW1wbC5qYXZh) | `0.77% <0.00%> (ø)` | |
| [.../src/main/java/com/cloud/vm/dao/UserVmDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC92bS9kYW8vVXNlclZtRGFvSW1wbC5qYXZh) | `0.75% <0.00%> (ø)` | |
| [.../cloud/baremetal/manager/BaremetalManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9iYXJlbWV0YWwvc3JjL21haW4vamF2YS9jb20vY2xvdWQvYmFyZW1ldGFsL21hbmFnZXIvQmFyZW1ldGFsTWFuYWdlckltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ck/network/contrail/model/VirtualMachineModel.java](https://codecov.io/gh/apache/cloudstack/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9WaXJ0dWFsTWFjaGluZU1vZGVsLmphdmE=) | `23.83% <ø> (ø)` | |
| [...ager/allocator/impl/UserConcentratedAllocator.java](https://codecov.io/gh/apache/cloudstack/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FnZW50L21hbmFnZXIvYWxsb2NhdG9yL2ltcGwvVXNlckNvbmNlbnRyYXRlZEFsbG9jYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ava/com/cloud/api/query/dao/UserVmJoinDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9xdWVyeS9kYW8vVXNlclZtSm9pbkRhb0ltcGwuamF2YQ==) | `3.22% <0.00%> (+0.01%)` | :arrow_up: |
| ... and [14 more](https://codecov.io/gh/apache/cloudstack/pull/7029/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1367802158
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1367926133
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1369008316
@DaanHoogland
could you please review this PR ? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#discussion_r1060422420
##########
api/src/main/java/com/cloud/vm/VirtualMachine.java:
##########
@@ -122,7 +123,8 @@ public static StateMachine2<State, VirtualMachine.Event, VirtualMachine> getStat
s_fsm.addTransition(new Transition<State, Event>(State.Stopping, VirtualMachine.Event.AgentReportStopped, State.Stopped, Arrays.asList(new Impact[]{Impact.USAGE})));
s_fsm.addTransition(new Transition<State, Event>(State.Stopping, VirtualMachine.Event.StopRequested, State.Stopping, null));
s_fsm.addTransition(new Transition<State, Event>(State.Stopping, VirtualMachine.Event.AgentReportShutdowned, State.Stopped, Arrays.asList(new Impact[]{Impact.USAGE})));
- s_fsm.addTransition(new Transition<State, Event>(State.Expunging, VirtualMachine.Event.OperationFailed, State.Expunging,null));
+ s_fsm.addTransition(new Transition<State, Event>(State.Expunging, VirtualMachine.Event.OperationSucceeded, State.Expunged, null));
+ s_fsm.addTransition(new Transition<State, Event>(State.Expunging, VirtualMachine.Event.OperationFailed, State.Error,null));
Review Comment:
sonar comment:
```suggestion
s_fsm.addTransition(new Transition<>(State.Expunging, VirtualMachine.Event.OperationSucceeded, State.Expunged, null));
s_fsm.addTransition(new Transition<>(State.Expunging, VirtualMachine.Event.OperationFailed, State.Error,null));
```
makes sense not to adhere to this old standard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1369689597
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1379950304
@DaanHoogland
moved to draft. let's revisit afterwards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1367925965
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1369614346
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1369658728
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1369647555
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1369724813
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1367828410
<b>Trillian Build Failed (tid-5710)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1370348468
<b>Trillian test result (tid-5735)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39894 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7029-t5735-kvm-centos7.zip
Smoke tests completed. 106 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1369648465
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1369725183
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1368110823
<b>Trillian test result (tid-5711)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43722 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7029-t5711-kvm-centos7.zip
Smoke tests completed. 106 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1368110399
<b>Trillian test result (tid-5709)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 44081 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7029-t5709-vmware-67u3.zip
Smoke tests completed. 106 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7029:
URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1381328475
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org