You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/05/02 09:10:19 UTC
[GitHub] [hudi] liujinhui1994 commented on a change in pull request #2710: [HUDI-648][RFC-20] Implement error log/table for Datasource/DeltaStreamer/WriteClient/Compaction writes
liujinhui1994 commented on a change in pull request #2710:
URL: https://github.com/apache/hudi/pull/2710#discussion_r624660295
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/error/HoodieBackedErrorTableWriter.java
##########
@@ -0,0 +1,247 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.error;
+
+import org.apache.avro.Schema;
+import org.apache.avro.generic.GenericData;
+import org.apache.avro.generic.GenericRecord;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hudi.avro.HoodieAvroUtils;
+import org.apache.hudi.client.WriteStatus;
+import org.apache.hudi.common.config.HoodieErrorTableConfig;
+import org.apache.hudi.common.config.SerializableConfiguration;
+import org.apache.hudi.common.engine.HoodieEngineContext;
+import org.apache.hudi.common.model.HoodieCleaningPolicy;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.model.HoodieRecordPayload;
+import org.apache.hudi.common.model.HoodieTableType;
+import org.apache.hudi.common.model.HoodieFileFormat;
+import org.apache.hudi.common.model.HoodieRecordLocation;
+import org.apache.hudi.common.model.OverwriteWithLatestAvroSchemaPayload;
+import org.apache.hudi.common.model.HoodieKey;
+import org.apache.hudi.common.model.HoodieAvroPayload;
+import org.apache.hudi.common.model.OverwriteWithLatestAvroPayload;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.StringUtils;
+import org.apache.hudi.config.HoodieCompactionConfig;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.table.HoodieTable;
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+import org.joda.time.DateTime;
+import org.joda.time.DateTimeZone;
+
+import java.io.IOException;
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.UUID;
+
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_COMMIT_TIME_METADATA_FIELD;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_RECORD_KEY_METADATA_FIELD;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_PARTITION_PATH_METADATA_FIELD;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_FILE_ID_FIELD;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_TABLE_NAME;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_RECORD_UUID;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_RECORD_TS;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_RECORD_SCHEMA;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_RECORD_RECORD;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_RECORD_MESSAGE;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_RECORD_CONTEXT;
+
+/**
+ * Writer implementation backed by an internal hudi table. Error records are saved within an internal COW table
+ * called Error table.
+ */
+public abstract class HoodieBackedErrorTableWriter<T extends HoodieRecordPayload, I, K, O> implements Serializable {
+
+ private static final Logger LOG = LogManager.getLogger(HoodieBackedErrorTableWriter.class);
+
+ protected HoodieWriteConfig errorTableWriteConfig;
+ protected HoodieWriteConfig datasetWriteConfig;
+ protected String tableName;
+
+ protected HoodieTableMetaClient metaClient;
+ protected SerializableConfiguration hadoopConf;
+ protected final transient HoodieEngineContext engineContext;
+ protected String basePath;
+
+ protected HoodieBackedErrorTableWriter(Configuration hadoopConf, HoodieWriteConfig writeConfig, HoodieEngineContext engineContext) {
+ this.datasetWriteConfig = writeConfig;
+ this.engineContext = engineContext;
+ this.hadoopConf = new SerializableConfiguration(hadoopConf);
+
+ if (writeConfig.errorTableEnabled()) {
+ this.tableName = writeConfig.getTableName() + HoodieErrorTableConfig.ERROR_TABLE_NAME_SUFFIX;
+ this.basePath = getErrorTableBasePath(writeConfig);
+ this.errorTableWriteConfig = createErrorDataWriteConfig(writeConfig);
+ initialize(engineContext, metaClient);
+ this.metaClient = HoodieTableMetaClient.builder()
+ .setConf(hadoopConf)
+ .setBasePath(errorTableWriteConfig.getBasePath()).build();
+ }
+ }
+
+ /**
+ * Create a {@code HoodieWriteConfig} to use for the Error Table.
+ *
+ * @param writeConfig {@code HoodieWriteConfig} of the main dataset writer
+ */
+ private HoodieWriteConfig createErrorDataWriteConfig(HoodieWriteConfig writeConfig) {
+ int parallelism = writeConfig.getErrorTableInsertParallelism();
+ // Create the write config for the metadata table by borrowing options from the main write config.
+ HoodieWriteConfig.Builder builder = HoodieWriteConfig.newBuilder()
+ .withEmbeddedTimelineServerEnabled(false)
+ .withPath(basePath)
+ .withSchema(HoodieErrorTableConfig.ERROR_TABLE_SCHEMA)
+ .forTable(getErrorTableName(writeConfig))
+ .withCompactionConfig(HoodieCompactionConfig.newBuilder()
+ .withCleanerPolicy(HoodieCleaningPolicy.KEEP_LATEST_COMMITS)
+ .retainCommits(writeConfig.getErrorTableCleanerCommitsRetained())
+ .archiveCommitsWith(writeConfig.getErrorTableMinCommitsToKeep(),
+ writeConfig.getMetadataMaxCommitsToKeep()).build())
+ .withParallelism(parallelism, parallelism);
+
+ return builder.build();
+ }
+
+ public HoodieWriteConfig getWriteConfig() {
Review comment:
ok, i will fix
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/error/HoodieBackedErrorTableWriter.java
##########
@@ -0,0 +1,247 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.error;
+
+import org.apache.avro.Schema;
+import org.apache.avro.generic.GenericData;
+import org.apache.avro.generic.GenericRecord;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hudi.avro.HoodieAvroUtils;
+import org.apache.hudi.client.WriteStatus;
+import org.apache.hudi.common.config.HoodieErrorTableConfig;
+import org.apache.hudi.common.config.SerializableConfiguration;
+import org.apache.hudi.common.engine.HoodieEngineContext;
+import org.apache.hudi.common.model.HoodieCleaningPolicy;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.model.HoodieRecordPayload;
+import org.apache.hudi.common.model.HoodieTableType;
+import org.apache.hudi.common.model.HoodieFileFormat;
+import org.apache.hudi.common.model.HoodieRecordLocation;
+import org.apache.hudi.common.model.OverwriteWithLatestAvroSchemaPayload;
+import org.apache.hudi.common.model.HoodieKey;
+import org.apache.hudi.common.model.HoodieAvroPayload;
+import org.apache.hudi.common.model.OverwriteWithLatestAvroPayload;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.StringUtils;
+import org.apache.hudi.config.HoodieCompactionConfig;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.table.HoodieTable;
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+import org.joda.time.DateTime;
+import org.joda.time.DateTimeZone;
+
+import java.io.IOException;
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.UUID;
+
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_COMMIT_TIME_METADATA_FIELD;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_RECORD_KEY_METADATA_FIELD;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_PARTITION_PATH_METADATA_FIELD;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_FILE_ID_FIELD;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_TABLE_NAME;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_RECORD_UUID;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_RECORD_TS;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_RECORD_SCHEMA;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_RECORD_RECORD;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_RECORD_MESSAGE;
+import static org.apache.hudi.common.config.HoodieErrorTableConfig.ERROR_RECORD_CONTEXT;
+
+/**
+ * Writer implementation backed by an internal hudi table. Error records are saved within an internal COW table
+ * called Error table.
+ */
+public abstract class HoodieBackedErrorTableWriter<T extends HoodieRecordPayload, I, K, O> implements Serializable {
+
+ private static final Logger LOG = LogManager.getLogger(HoodieBackedErrorTableWriter.class);
+
+ protected HoodieWriteConfig errorTableWriteConfig;
+ protected HoodieWriteConfig datasetWriteConfig;
+ protected String tableName;
+
+ protected HoodieTableMetaClient metaClient;
+ protected SerializableConfiguration hadoopConf;
+ protected final transient HoodieEngineContext engineContext;
+ protected String basePath;
+
+ protected HoodieBackedErrorTableWriter(Configuration hadoopConf, HoodieWriteConfig writeConfig, HoodieEngineContext engineContext) {
+ this.datasetWriteConfig = writeConfig;
+ this.engineContext = engineContext;
+ this.hadoopConf = new SerializableConfiguration(hadoopConf);
+
+ if (writeConfig.errorTableEnabled()) {
+ this.tableName = writeConfig.getTableName() + HoodieErrorTableConfig.ERROR_TABLE_NAME_SUFFIX;
+ this.basePath = getErrorTableBasePath(writeConfig);
+ this.errorTableWriteConfig = createErrorDataWriteConfig(writeConfig);
+ initialize(engineContext, metaClient);
+ this.metaClient = HoodieTableMetaClient.builder()
+ .setConf(hadoopConf)
+ .setBasePath(errorTableWriteConfig.getBasePath()).build();
+ }
+ }
+
+ /**
+ * Create a {@code HoodieWriteConfig} to use for the Error Table.
+ *
+ * @param writeConfig {@code HoodieWriteConfig} of the main dataset writer
+ */
+ private HoodieWriteConfig createErrorDataWriteConfig(HoodieWriteConfig writeConfig) {
+ int parallelism = writeConfig.getErrorTableInsertParallelism();
+ // Create the write config for the metadata table by borrowing options from the main write config.
+ HoodieWriteConfig.Builder builder = HoodieWriteConfig.newBuilder()
+ .withEmbeddedTimelineServerEnabled(false)
+ .withPath(basePath)
+ .withSchema(HoodieErrorTableConfig.ERROR_TABLE_SCHEMA)
+ .forTable(getErrorTableName(writeConfig))
+ .withCompactionConfig(HoodieCompactionConfig.newBuilder()
+ .withCleanerPolicy(HoodieCleaningPolicy.KEEP_LATEST_COMMITS)
+ .retainCommits(writeConfig.getErrorTableCleanerCommitsRetained())
+ .archiveCommitsWith(writeConfig.getErrorTableMinCommitsToKeep(),
+ writeConfig.getMetadataMaxCommitsToKeep()).build())
+ .withParallelism(parallelism, parallelism);
+
+ return builder.build();
+ }
+
+ public HoodieWriteConfig getWriteConfig() {
+ return errorTableWriteConfig;
+ }
+
+ /**
+ * Init if hudi error table not exit.
+ * @param datasetMetaClient
+ * @throws IOException
+ */
+ protected void bootstrapErrorTable(HoodieTableMetaClient datasetMetaClient) throws IOException {
+
+ if (datasetMetaClient == null) {
+ HoodieTableMetaClient.withPropertyBuilder()
+ .setTableType(HoodieTableType.COPY_ON_WRITE)
+ .setTableName(tableName)
+ .setArchiveLogFolder("archived")
+ .setPayloadClassName(OverwriteWithLatestAvroPayload.class.getName())
+ .setBaseFileFormat(HoodieFileFormat.PARQUET.toString())
+ .initTable(new Configuration(hadoopConf.get()), errorTableWriteConfig.getBasePath());
+ } else {
+ boolean exists = datasetMetaClient.getFs().exists(new Path(errorTableWriteConfig.getBasePath(), HoodieTableMetaClient.METAFOLDER_NAME));
+ if (!exists) {
+ HoodieTableMetaClient.withPropertyBuilder()
+ .setTableType(HoodieTableType.COPY_ON_WRITE)
+ .setTableName(tableName)
+ .setArchiveLogFolder("archived")
+ .setPayloadClassName(OverwriteWithLatestAvroPayload.class.getName())
+ .setBaseFileFormat(HoodieFileFormat.PARQUET.toString())
+ .initTable(new Configuration(hadoopConf.get()), errorTableWriteConfig.getBasePath());
Review comment:
ok, i will fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org