[GitHub] [kafka] ijuma commented on a diff in pull request #12830: KAFKA-8115: Reduce flakiness in Trogdor JsonRestServer shutdown

["ijuma (via GitHub)" <gi...@apache.org>]

ijuma commented on code in PR #12830:
URL: https://github.com/apache/kafka/pull/12830#discussion_r1167565330


##########
trogdor/src/main/java/org/apache/kafka/trogdor/rest/JsonRestServer.java:
##########
@@ -138,13 +138,13 @@ public void beginShutdown() {
                     log.info("Stopping REST server");
                     jettyServer.stop();
                     jettyServer.join();
+                    jettyServer.destroy();
                     log.info("REST server stopped");
                 } catch (Exception e) {
                     log.error("Unable to stop REST server", e);
                 } finally {
-                    jettyServer.destroy();
+                    shutdownExecutor.shutdown();

Review Comment:
   Shouldn't jetty.destroy remain in the finally and maybe we catch any exceptions it throws?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org