You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2023/01/11 05:03:30 UTC
[GitHub] [hudi] trushev opened a new pull request, #7641: [MINOR] Fix flaky tests in ITTestHoodieDataSource caused by unordered hashmap
trushev opened a new pull request, #7641:
URL: https://github.com/apache/hudi/pull/7641
This PR fixes flaky tests in `ITTestHoodieDataSource`.
Tests sometimes are failed because they do the check `hashMap1.toString().equals(hashMap2.toString())` while hashmap does not guarantee that the order of entries will remain constant over time
### Change Logs
Replaced the check `hashMap1.toString().equals(hashMap2.toString())` with `hashMap1.equals(hashMap2)`
### Impact
Fixed `testParquetComplexTypes` and `testParquetComplexNestedRowTypes` failed with assertion
```
java.lang.AssertionError:
Expected: is "[+I[1, [abc1, def1], {abc1=1, def1=3}, +I[1, abc1]], +I[2, [abc2, def2], {def2=3, abc2=1}, +I[2, abc2]], +I[3, [abc3, def3], {def3=3, abc3=1}, +I[3, abc3]]]"
but: was "[+I[1, [abc1, def1], {def1=3, abc1=1}, +I[1, abc1]], +I[2, [abc2, def2], {def2=3, abc2=1}, +I[2, abc2]], +I[3, [abc3, def3], {def3=3, abc3=1}, +I[3, abc3]]]"
```
where `{abc1=1, def1=3}` != `{def1=3, abc1=1}`
### Risk level (write none, low medium or high below)
None
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7641: [MINOR] Fix flaky tests in ITTestHoodieDataSource caused by unordered hashmap
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #7641:
URL: https://github.com/apache/hudi/pull/7641#discussion_r1066626694
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestHoodieDataSource.java:
##########
@@ -1753,4 +1756,27 @@ private List<Row> execSelectSql(TableEnvironment tEnv, String select, String sin
.flatMap(Collection::stream)
.collect(Collectors.toList());
}
+
+ private Row row(Object... args) {
+ return Row.of(args);
+ }
Review Comment:
Can we move these utilities to `TestData.java` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7641: [MINOR] Fix flaky tests in ITTestHoodieDataSource caused by unordered hashmap
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7641:
URL: https://github.com/apache/hudi/pull/7641#issuecomment-1378413157
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7c07e6f8760f776d15ed07ca2819d14d15ad9f86",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14238",
"triggerID" : "7c07e6f8760f776d15ed07ca2819d14d15ad9f86",
"triggerType" : "PUSH"
}, {
"hash" : "5f2475c467d00029e7a0cbfa51a56739d97cd196",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f2475c467d00029e7a0cbfa51a56739d97cd196",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7c07e6f8760f776d15ed07ca2819d14d15ad9f86 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14238)
* 5f2475c467d00029e7a0cbfa51a56739d97cd196 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] trushev commented on a diff in pull request #7641: [MINOR] Fix flaky tests in ITTestHoodieDataSource caused by unordered hashmap
Posted by GitBox <gi...@apache.org>.
trushev commented on code in PR #7641:
URL: https://github.com/apache/hudi/pull/7641#discussion_r1066698995
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestHoodieDataSource.java:
##########
@@ -1753,4 +1756,27 @@ private List<Row> execSelectSql(TableEnvironment tEnv, String select, String sin
.flatMap(Collection::stream)
.collect(Collectors.toList());
}
+
+ private Row row(Object... args) {
+ return Row.of(args);
+ }
Review Comment:
Moved to `TestData`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7641: [MINOR] Fix flaky tests in ITTestHoodieDataSource caused by unordered hashmap
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7641:
URL: https://github.com/apache/hudi/pull/7641#issuecomment-1378271347
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7c07e6f8760f776d15ed07ca2819d14d15ad9f86",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7c07e6f8760f776d15ed07ca2819d14d15ad9f86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7c07e6f8760f776d15ed07ca2819d14d15ad9f86 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7641: [MINOR] Fix flaky tests in ITTestHoodieDataSource caused by unordered hashmap
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7641:
URL: https://github.com/apache/hudi/pull/7641#issuecomment-1378275287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7c07e6f8760f776d15ed07ca2819d14d15ad9f86",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14238",
"triggerID" : "7c07e6f8760f776d15ed07ca2819d14d15ad9f86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7c07e6f8760f776d15ed07ca2819d14d15ad9f86 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14238)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7641: [MINOR] Fix flaky tests in ITTestHoodieDataSource caused by unordered hashmap
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7641:
URL: https://github.com/apache/hudi/pull/7641#issuecomment-1378420843
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7c07e6f8760f776d15ed07ca2819d14d15ad9f86",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14238",
"triggerID" : "7c07e6f8760f776d15ed07ca2819d14d15ad9f86",
"triggerType" : "PUSH"
}, {
"hash" : "5f2475c467d00029e7a0cbfa51a56739d97cd196",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14241",
"triggerID" : "5f2475c467d00029e7a0cbfa51a56739d97cd196",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7c07e6f8760f776d15ed07ca2819d14d15ad9f86 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14238)
* 5f2475c467d00029e7a0cbfa51a56739d97cd196 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14241)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #7641: [MINOR] Fix flaky tests in ITTestHoodieDataSource caused by unordered hashmap
Posted by GitBox <gi...@apache.org>.
danny0405 merged PR #7641:
URL: https://github.com/apache/hudi/pull/7641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7641: [MINOR] Fix flaky tests in ITTestHoodieDataSource caused by unordered hashmap
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7641:
URL: https://github.com/apache/hudi/pull/7641#issuecomment-1378843242
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7c07e6f8760f776d15ed07ca2819d14d15ad9f86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14238",
"triggerID" : "7c07e6f8760f776d15ed07ca2819d14d15ad9f86",
"triggerType" : "PUSH"
}, {
"hash" : "5f2475c467d00029e7a0cbfa51a56739d97cd196",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14241",
"triggerID" : "5f2475c467d00029e7a0cbfa51a56739d97cd196",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f2475c467d00029e7a0cbfa51a56739d97cd196 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14241)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org