[GitHub] [flink] fhueske commented on issue #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

[GitBox <gi...@apache.org>]

fhueske commented on issue #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…
URL: https://github.com/apache/flink/pull/8844#issuecomment-510087843
 
 
   Hi,
   
   I noticed that this PR introduces significant changes to the public API of `TableEnvironment`, i.e., deprecating `sqlQuery()` and `sqlUpdate()` and introducing `sql()`. AFAIK, there was no consensus to remove `sqlQuery()` and `sqlUpdate()`.
   
   Originally we had only `sql()` and moved to `sqlQuery()` and `sqlUpdate()` when introducing support for `INSERT INTO` queries and table sinks. I remember these interfaces were the result and consensus of a long discussion. See #3829 and this shorter thread on the [dev ML](https://lists.apache.org/thread.html/844a9b8a009706de801b0d9746f9a193fce4a197cc11632a4f4fd39d@%3Cdev.flink.apache.org%3E). 
   
   Since many users are relying on these interfaces, we should have a discussion on the dev mailing list before deprecating them. Oftentimes, public interfaces are the result of community discussions which become somewhat pointless when the APIs are changed afterwards.
   
   I'm not saying that these are bad changes. Maybe the requirements for the APIs changed, but this should definitely be discussed with the community. Also, I'm not a big fan of rushing changes to core APIs into the master so close a to a feature freeze.
   
   Best, Fabian

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services