You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2013/01/03 21:03:46 UTC

svn commit: r1428566 - in /lucene/dev/branches/branch_4x: ./ lucene/ lucene/core/ lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java

Author: rmuir
Date: Thu Jan  3 20:03:46 2013
New Revision: 1428566

URL: http://svn.apache.org/viewvc?rev=1428566&view=rev
Log:
add commented out assert that finds more bugs

Modified:
    lucene/dev/branches/branch_4x/   (props changed)
    lucene/dev/branches/branch_4x/lucene/   (props changed)
    lucene/dev/branches/branch_4x/lucene/core/   (props changed)
    lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java

Modified: lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java?rev=1428566&r1=1428565&r2=1428566&view=diff
==============================================================================
--- lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java (original)
+++ lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java Thu Jan  3 20:03:46 2013
@@ -1045,16 +1045,15 @@ public class TestIndexWriter extends Luc
               }
               if (random.nextInt(3) == 0) {
                 IndexReader r = null;
-                boolean success = false;
                 try {
                   r = DirectoryReader.open(w, random.nextBoolean());
-                  success = true;
+                  // TODO: more bugs!
+                  // if (random.nextBoolean() && r.maxDoc() > 0) {
+                  //  int docid = random.nextInt(r.maxDoc());
+                  //  w.tryDeleteDocument(r, docid);
+                  //}
                 } finally {
-                  if (success) {
-                    r.close();
-                  } else {
-                    IOUtils.closeWhileHandlingException(r);
-                  }
+                  IOUtils.closeWhileHandlingException(r);
                 }
               }
               if (i%10 == 0) {