You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/08/15 03:42:08 UTC
[GitHub] [hive] jcamachor opened a new pull request #1405: HIVE-24041: Extend semijoin conversion rules
jcamachor opened a new pull request #1405:
URL: https://github.com/apache/hive/pull/1405
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz commented on a change in pull request #1405: HIVE-24041: Extend semijoin conversion rules
Posted by GitBox <gi...@apache.org>.
kasakrisz commented on a change in pull request #1405:
URL: https://github.com/apache/hive/pull/1405#discussion_r476169201
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSemiJoinRule.java
##########
@@ -33,194 +37,263 @@
import org.apache.calcite.rex.RexBuilder;
import org.apache.calcite.rex.RexNode;
import org.apache.calcite.tools.RelBuilder;
+import org.apache.calcite.tools.RelBuilder.GroupKey;
import org.apache.calcite.tools.RelBuilderFactory;
import org.apache.calcite.util.ImmutableBitSet;
+import org.apache.calcite.util.ImmutableIntList;
+import org.apache.hadoop.hive.ql.optimizer.calcite.HiveCalciteUtil;
import org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import com.google.common.collect.ImmutableList;
-import com.google.common.collect.Lists;
import java.util.ArrayList;
import java.util.List;
/**
- * Planner rule that creates a {@code SemiJoinRule} from a
- * {@link org.apache.calcite.rel.core.Join} on top of a
- * {@link org.apache.calcite.rel.logical.LogicalAggregate}.
- *
- * TODO Remove this rule and use Calcite's SemiJoinRule. Not possible currently
- * since Calcite doesnt use RelBuilder for this rule and we want to generate HiveSemiJoin rel here.
+ * Class that gathers SemiJoin conversion rules.
*/
-public abstract class HiveSemiJoinRule extends RelOptRule {
+public class HiveSemiJoinRule {
- protected static final Logger LOG = LoggerFactory.getLogger(HiveSemiJoinRule.class);
+ public static final HiveProjectJoinToSemiJoinRule INSTANCE_PROJECT =
+ new HiveProjectJoinToSemiJoinRule(HiveRelFactories.HIVE_BUILDER);
- public static final HiveProjectToSemiJoinRule INSTANCE_PROJECT =
- new HiveProjectToSemiJoinRule(HiveRelFactories.HIVE_BUILDER);
+ public static final HiveAggregateJoinToSemiJoinRule INSTANCE_AGGREGATE =
+ new HiveAggregateJoinToSemiJoinRule(HiveRelFactories.HIVE_BUILDER);
- public static final HiveProjectToSemiJoinRuleSwapInputs INSTANCE_PROJECT_SWAPPED =
- new HiveProjectToSemiJoinRuleSwapInputs(HiveRelFactories.HIVE_BUILDER);
+ public static final HiveProjectJoinToSemiJoinRuleSwapInputs INSTANCE_PROJECT_SWAPPED =
+ new HiveProjectJoinToSemiJoinRuleSwapInputs(HiveRelFactories.HIVE_BUILDER);
- public static final HiveAggregateToSemiJoinRule INSTANCE_AGGREGATE =
- new HiveAggregateToSemiJoinRule(HiveRelFactories.HIVE_BUILDER);
+ public static final HiveAggregateJoinToSemiJoinRuleSwapInputs INSTANCE_AGGREGATE_SWAPPED =
+ new HiveAggregateJoinToSemiJoinRuleSwapInputs(HiveRelFactories.HIVE_BUILDER);
Review comment:
nit.: Is the parameter value always `HiveRelFactories.HIVE_BUILDER` ? It can be moved to the base class as a constant.
##########
File path: ql/src/test/queries/clientpositive/auto_sortmerge_join_10.q
##########
@@ -48,6 +48,8 @@ select count(*) from
(select a.key as key, a.value as value from tbl2_n4 a where key < 6) subq2
on subq1.key = subq2.key;
+set hive.auto.convert.sortmerge.join=false;
Review comment:
Based on the test filename this test intend to test automatic conversion to a sort-merge join but it is not tested anymore if the feature is turned off.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jcamachor commented on a change in pull request #1405: HIVE-24041: Extend semijoin conversion rules
Posted by GitBox <gi...@apache.org>.
jcamachor commented on a change in pull request #1405:
URL: https://github.com/apache/hive/pull/1405#discussion_r476489342
##########
File path: ql/src/test/queries/clientpositive/auto_sortmerge_join_10.q
##########
@@ -48,6 +48,8 @@ select count(*) from
(select a.key as key, a.value as value from tbl2_n4 a where key < 6) subq2
on subq1.key = subq2.key;
+set hive.auto.convert.sortmerge.join=false;
Review comment:
Yes, this will be tackled in follow-up by @maheshk114 , there is a problem with execution of semijoin. I will reference the JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jcamachor merged pull request #1405: HIVE-24041: Extend semijoin conversion rules
Posted by GitBox <gi...@apache.org>.
jcamachor merged pull request #1405:
URL: https://github.com/apache/hive/pull/1405
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jcamachor commented on pull request #1405: HIVE-24041: Extend semijoin conversion rules
Posted by GitBox <gi...@apache.org>.
jcamachor commented on pull request #1405:
URL: https://github.com/apache/hive/pull/1405#issuecomment-680285026
@kasakrisz , I have addressed the comment and all tests passed. I'll link the JIRA for semijoin SMB to this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jcamachor commented on a change in pull request #1405: HIVE-24041: Extend semijoin conversion rules
Posted by GitBox <gi...@apache.org>.
jcamachor commented on a change in pull request #1405:
URL: https://github.com/apache/hive/pull/1405#discussion_r476491640
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSemiJoinRule.java
##########
@@ -33,194 +37,263 @@
import org.apache.calcite.rex.RexBuilder;
import org.apache.calcite.rex.RexNode;
import org.apache.calcite.tools.RelBuilder;
+import org.apache.calcite.tools.RelBuilder.GroupKey;
import org.apache.calcite.tools.RelBuilderFactory;
import org.apache.calcite.util.ImmutableBitSet;
+import org.apache.calcite.util.ImmutableIntList;
+import org.apache.hadoop.hive.ql.optimizer.calcite.HiveCalciteUtil;
import org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import com.google.common.collect.ImmutableList;
-import com.google.common.collect.Lists;
import java.util.ArrayList;
import java.util.List;
/**
- * Planner rule that creates a {@code SemiJoinRule} from a
- * {@link org.apache.calcite.rel.core.Join} on top of a
- * {@link org.apache.calcite.rel.logical.LogicalAggregate}.
- *
- * TODO Remove this rule and use Calcite's SemiJoinRule. Not possible currently
- * since Calcite doesnt use RelBuilder for this rule and we want to generate HiveSemiJoin rel here.
+ * Class that gathers SemiJoin conversion rules.
*/
-public abstract class HiveSemiJoinRule extends RelOptRule {
+public class HiveSemiJoinRule {
- protected static final Logger LOG = LoggerFactory.getLogger(HiveSemiJoinRule.class);
+ public static final HiveProjectJoinToSemiJoinRule INSTANCE_PROJECT =
+ new HiveProjectJoinToSemiJoinRule(HiveRelFactories.HIVE_BUILDER);
- public static final HiveProjectToSemiJoinRule INSTANCE_PROJECT =
- new HiveProjectToSemiJoinRule(HiveRelFactories.HIVE_BUILDER);
+ public static final HiveAggregateJoinToSemiJoinRule INSTANCE_AGGREGATE =
+ new HiveAggregateJoinToSemiJoinRule(HiveRelFactories.HIVE_BUILDER);
- public static final HiveProjectToSemiJoinRuleSwapInputs INSTANCE_PROJECT_SWAPPED =
- new HiveProjectToSemiJoinRuleSwapInputs(HiveRelFactories.HIVE_BUILDER);
+ public static final HiveProjectJoinToSemiJoinRuleSwapInputs INSTANCE_PROJECT_SWAPPED =
+ new HiveProjectJoinToSemiJoinRuleSwapInputs(HiveRelFactories.HIVE_BUILDER);
- public static final HiveAggregateToSemiJoinRule INSTANCE_AGGREGATE =
- new HiveAggregateToSemiJoinRule(HiveRelFactories.HIVE_BUILDER);
+ public static final HiveAggregateJoinToSemiJoinRuleSwapInputs INSTANCE_AGGREGATE_SWAPPED =
+ new HiveAggregateJoinToSemiJoinRuleSwapInputs(HiveRelFactories.HIVE_BUILDER);
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org