[GitHub] [incubator-zipkin] michaelsembwever commented on issue #2548: Sort out DEPENDENCIES file for zipkin-lens

[GitBox <gi...@apache.org>]

michaelsembwever commented on issue #2548: Sort out DEPENDENCIES file for zipkin-lens
URL: https://github.com/apache/incubator-zipkin/issues/2548#issuecomment-499376855
 
 
   I also used `license-checker` on Cassandra Reaper when we offered to donate it to Cassandra.
   
   > … the format needs of DEPENDENCIES …
   
   no idea :(
   but my understanding was that it is just an exercise to ensure copyleft dependencies don't sneak in. (it is very easy to slip in a dependency via a PR without properly double-checking it.)
   
   >  How do we handle the above licenses / uses?
   
   I think the whitelist approach to the `license-checker` is a good approach. It is only going to break when a new dependency is added and that dependency uses a new and acceptable license. Adding that license to the whitelist can be done on-demand as part of adding that dependency. That's how I would tackle (defer) the process at least.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services