You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by ilooner <gi...@git.apache.org> on 2015/09/29 23:16:44 UTC

[GitHub] incubator-apex-malhar pull request: - MLHR-1863 #resolve #comment ...

GitHub user ilooner opened a pull request:

    https://github.com/apache/incubator-apex-malhar/pull/43

     - MLHR-1863 #resolve #comment Make time buckets comparable.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ilooner/incubator-apex-malhar MLHR-1863

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-apex-malhar/pull/43.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #43
    
----
commit 24248f77cab0b7239238b6d2ab953b6be330a545
Author: Timothy Farkas <ti...@datatorrent.com>
Date:   2015-09-29T19:35:16Z

     - MLHR-1863 #resolve #comment Make time buckets comparable.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-malhar pull request: - MLHR-1863 #resolve #comment ...

Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/43#discussion_r40736636
  
    --- Diff: library/src/main/java/com/datatorrent/lib/appdata/schemas/TimeBucketComparator.java ---
    @@ -0,0 +1,34 @@
    +/*
    + * Copyright (c) 2015 DataTorrent
    + *
    + * Licensed under the Apache License, Version 2.0 (the "License");
    + * you may not use this file except in compliance with the License.
    + * You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package com.datatorrent.lib.appdata.schemas;
    +
    +import java.util.Comparator;
    +
    +public class TimeBucketComparator implements Comparator<TimeBucket>
    --- End diff --
    
    Can this be inside TimeBucket.java?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-malhar pull request: - MLHR-1863 #resolve #comment ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-apex-malhar/pull/43


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---