You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org> on 2012/06/26 19:21:42 UTC
[jira] [Created] (HBASE-6273) HMasterInterface.isMasterRunning()
requires clean up
ramkrishna.s.vasudevan created HBASE-6273:
---------------------------------------------
Summary: HMasterInterface.isMasterRunning() requires clean up
Key: HBASE-6273
URL: https://issues.apache.org/jira/browse/HBASE-6273
Project: HBase
Issue Type: Bug
Components: master
Affects Versions: 0.94.0
Reporter: ramkrishna.s.vasudevan
Fix For: 0.94.1
This JIRA is in reference to JD's comments regarding the clean up needed in isMasterRunning(). Refer to
https://issues.apache.org/jira/browse/HBASE-6240?focusedCommentId=13400772&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13400772
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6273) HMasterInterface.isMasterRunning()
requires clean up
Posted by "nkeywal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402064#comment-13402064 ]
nkeywal commented on HBASE-6273:
--------------------------------
+1 as well. Errors can be:
1) Can't connect to ZK -> Hence you can't get the master address. This is especially true in 0.96 as the connection to ZK is made on demand. I think we need to have/keep this as an exception
2) There is no info on the master address in ZK. We should make this clear as well. The best option I see is a specific exception such as NoMasterAddressException or NoMasterAddressInZooKeeperException
And MasterNotRunning can be: the master is actually there, but marked internally as non running (stopped). The server side method 'isMasterRunning' will return false (you can contact the master but it's stopping). As such I think is better not to have an exception named MasterNotRunning as it creates confusion between the technical status and the functional one.
I think the pseudo code could be, on the client interface:
{noformat}
public boolean isMasterRunning() throws MasterConnectionException, NoMasterAddressException, ZooKeeperConnectionException {
ZK zk = getZK(); // Can throw ZooKeeperConnectionException
Master m = getMaster(zk); // Can throw MasterConnectionException or NoMasterAddressException
boolean isRunning = m.isMasterRunning(); // can throw MasterConnectionException
return isRunning;
}
{noformat}
> HMasterInterface.isMasterRunning() requires clean up
> ----------------------------------------------------
>
> Key: HBASE-6273
> URL: https://issues.apache.org/jira/browse/HBASE-6273
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: ramkrishna.s.vasudevan
> Fix For: 0.96.0
>
>
> This JIRA is in reference to JD's comments regarding the clean up needed in isMasterRunning(). Refer to
> https://issues.apache.org/jira/browse/HBASE-6240?focusedCommentId=13400772&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13400772
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6273) HMasterInterface.isMasterRunning()
requires clean up
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402480#comment-13402480 ]
Jean-Daniel Cryans commented on HBASE-6273:
-------------------------------------------
+1
> HMasterInterface.isMasterRunning() requires clean up
> ----------------------------------------------------
>
> Key: HBASE-6273
> URL: https://issues.apache.org/jira/browse/HBASE-6273
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.96.0
>
>
> This JIRA is in reference to JD's comments regarding the clean up needed in isMasterRunning(). Refer to
> https://issues.apache.org/jira/browse/HBASE-6240?focusedCommentId=13400772&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13400772
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6273) HMasterInterface.isMasterRunning()
requires clean up
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anoop Sam John updated HBASE-6273:
----------------------------------
Fix Version/s: (was: 0.94.1)
0.96.0
> HMasterInterface.isMasterRunning() requires clean up
> ----------------------------------------------------
>
> Key: HBASE-6273
> URL: https://issues.apache.org/jira/browse/HBASE-6273
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: ramkrishna.s.vasudevan
> Fix For: 0.96.0
>
>
> This JIRA is in reference to JD's comments regarding the clean up needed in isMasterRunning(). Refer to
> https://issues.apache.org/jira/browse/HBASE-6240?focusedCommentId=13400772&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13400772
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-6273) HMasterInterface.isMasterRunning()
requires clean up
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan reassigned HBASE-6273:
---------------------------------------------
Assignee: ramkrishna.s.vasudevan
> HMasterInterface.isMasterRunning() requires clean up
> ----------------------------------------------------
>
> Key: HBASE-6273
> URL: https://issues.apache.org/jira/browse/HBASE-6273
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.96.0
>
>
> This JIRA is in reference to JD's comments regarding the clean up needed in isMasterRunning(). Refer to
> https://issues.apache.org/jira/browse/HBASE-6240?focusedCommentId=13400772&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13400772
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6273) HMasterInterface.isMasterRunning()
requires clean up
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401882#comment-13401882 ]
Lars Hofhansl commented on HBASE-6273:
--------------------------------------
+1 on both counts (two exceptions, and not a in point release)
> HMasterInterface.isMasterRunning() requires clean up
> ----------------------------------------------------
>
> Key: HBASE-6273
> URL: https://issues.apache.org/jira/browse/HBASE-6273
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: ramkrishna.s.vasudevan
> Fix For: 0.94.1
>
>
> This JIRA is in reference to JD's comments regarding the clean up needed in isMasterRunning(). Refer to
> https://issues.apache.org/jira/browse/HBASE-6240?focusedCommentId=13400772&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13400772
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6273) HMasterInterface.isMasterRunning()
requires clean up
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401552#comment-13401552 ]
Jean-Daniel Cryans commented on HBASE-6273:
-------------------------------------------
I think we should have two exceptions:
- MasterNotRunning (you can contact the machine, but you get a connection refused and maybe I'd include PleaseHoldException)
- MasterUnreachable (Unknown host, EOF, and probably other IOEs)
This will really help operability, it happened a couple of time on the mailing list that someone would say "I got MasterNotRunning but it's running I can use it" when all they had was a connectivity issue.
I'd prefer we don't do this for a point release.
> HMasterInterface.isMasterRunning() requires clean up
> ----------------------------------------------------
>
> Key: HBASE-6273
> URL: https://issues.apache.org/jira/browse/HBASE-6273
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: ramkrishna.s.vasudevan
> Fix For: 0.94.1
>
>
> This JIRA is in reference to JD's comments regarding the clean up needed in isMasterRunning(). Refer to
> https://issues.apache.org/jira/browse/HBASE-6240?focusedCommentId=13400772&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13400772
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira