[GitHub] [helix] pkuwm commented on pull request #1292: Remove closed ZKConnectionManager from connection manager pool

[GitBox <gi...@apache.org>]

pkuwm commented on pull request #1292:
URL: https://github.com/apache/helix/pull/1292#issuecomment-676669851


   > > I am trying understand why this test is failing in CI but passing locally
   > 
   > > java.lang.AssertionError: expected:<0> but was:<1>
   > 
   > > at org.apache.helix.zookeeper.impl.client.TestRawZkClient.testZkClientMonitor(TestRawZkClient.java:288)
   > 
   > > 
   > 
   > > [INFO]
   > 
   > > [INFO] Results:
   > 
   > > [INFO]
   > 
   > > [ERROR] Failures:
   > 
   > > [ERROR] TestRawZkClient.testZkClientMonitor:288 expected:<0> but was:<1>
   > 
   > > [INFO]
   > 
   > > [ERROR] Tests run: 44, Failures: 1, Errors: 0, Skipped: 2
   > 
   > 
   > 
   > @jiajunwang @pkuwm @kaisun2000  is this test a failing item in CI? Has our CI been made stable yet?
   
   @narendly From the ci result, it is still a failure. Being successful in local is because the ordering of tests running is different with CI. I believe @kaisun2000 is working on fixing the failed tests. Maybe @kaisun2000 could prioritize this test fix so zookeeper api module can pass tests?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org