[jira] [Comment Edited] (MDEP-602) Turn warnings into errors instead of failOnWarning

["Halil İbrahim Şener (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MDEP-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541701#comment-17541701 ] 

Halil İbrahim Şener edited comment on MDEP-602 at 8/10/22 5:21 PM:
-------------------------------------------------------------------

I agree that it's unexpected that warnings are breaking the build, and I got questions about this before.

In https://issues.apache.org/jira/browse/MENFORCER-409, the Maven enforcer plugin also changes the log level when {{fail}} is set to {{true}}. I created a PR to do the same in the Maven dependency plugin: https://github.com/apache/maven-dependency-plugin/pull/219.


was (Author: hisener):
I agree that it's unexpected that warnings are breaking the build, and I was got questions about this before.

In https://issues.apache.org/jira/browse/MENFORCER-409, the Maven enforcer plugin also changes the log level when {{fail}} is set to {{true}}. I created a PR to do the same in the Maven dependency plugin: https://github.com/apache/maven-dependency-plugin/pull/219.

> Turn warnings into errors instead of failOnWarning
> --------------------------------------------------
>
>                 Key: MDEP-602
>                 URL: https://issues.apache.org/jira/browse/MDEP-602
>             Project: Maven Dependency Plugin
>          Issue Type: Improvement
>          Components: analyze
>    Affects Versions: 3.0.2
>            Reporter: Richard Eckart de Castilho
>            Assignee: Slawomir Jaranowski
>            Priority: Minor
>              Labels: S2
>             Fix For: next-release
>
>
> Currently, the dependency:analyze goal supports a parameter called failOnWarning which - when enabled - causes warnings to fail the build.
> This is confusing, especially for new developers on a team who are often unable to locate the dependency problems causing the build to fail in the logs because they only look for "error" level messages.
> To avoid such problems, I would suggest deprecating the failOnWarning parameter, and instead introduce a new parameter such as treatDependencyProblemsAs which could take as a default level "warning" and which users could alternatively set to "error".
> I am setting this as a "major improvement" because in my experience, it causes significant confusion over and over again.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)