[GitHub] wu-sheng commented on issue #1310: Does the config : agent.sample_n_per_3_secs support such a way like this : 10% 、20% and does the config file : agent.config support dynamic loading?

[GitBox <gi...@apache.org>]

wu-sheng commented on issue #1310: Does the config : agent.sample_n_per_3_secs support such a way like this : 10% 、20% and does the config file : agent.config support dynamic loading?
URL: https://github.com/apache/incubator-skywalking/issues/1310#issuecomment-394605824
 
 
   > agent.sample_n_per_3_secs support such a way like this : 10% 、20%
   
   No. But if you want, you could contribute a new optional plugin to support this sample mechanism.  Override `SamplingService` service, by learning from `/apm-sniffer/optional-plugins/trace-ignore-plugin`. This plugin overrides `TraceIgnoreExtendService` service to support new feature.
   
   Welcome to join the community.
   
   > does the config file : agent.config support dynamic loading
   
   This is not an easy YES or NO question. Because some settings, such as application code, buffer size, are hard to change in runtime. So I suggest you focus on which settings do you want to dynamic reload.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services