You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2020/08/29 14:40:53 UTC
[GitHub] [jena] afs opened a new pull request #789: JENA-1957: Extensions: targetClass=, missing propertyParams and NodeS…
afs opened a new pull request #789:
URL: https://github.com/apache/jena/pull/789
…hape sh:node.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] rvesse commented on a change in pull request #789: JENA-1957: targetClass=, missing propertyParams, NodeShape sh:node.
Posted by GitBox <gi...@apache.org>.
rvesse commented on a change in pull request #789:
URL: https://github.com/apache/jena/pull/789#discussion_r480993050
##########
File path: jena-base/src/main/java/org/apache/jena/atlas/lib/CollectionUtils.java
##########
@@ -31,6 +32,10 @@
/** Return an element from a collection. */
public static <T> T oneElt(Collection<T> collection) {
+ if ( collection.isEmpty() )
Review comment:
Should this method have a `null` check for `collection`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a change in pull request #789: JENA-1957: targetClass=, missing propertyParams, NodeShape sh:node.
Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #789:
URL: https://github.com/apache/jena/pull/789#discussion_r481088290
##########
File path: jena-base/src/main/java/org/apache/jena/atlas/lib/CollectionUtils.java
##########
@@ -31,6 +32,10 @@
/** Return an element from a collection. */
public static <T> T oneElt(Collection<T> collection) {
+ if ( collection.isEmpty() )
Review comment:
Done (the calls were safe anyway).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #789: JENA-1957: targetClass=, missing propertyParams, NodeShape sh:node.
Posted by GitBox <gi...@apache.org>.
afs merged pull request #789:
URL: https://github.com/apache/jena/pull/789
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org