You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Rüdiger Plüm <r....@gmx.de> on 2010/02/03 20:45:17 UTC
Re: svn commit: r905970 - in /apr/apr/trunk: file_io/unix/filedup.c
file_io/unix/open.c file_io/unix/readwrite.c include/apr_file_io.h include/arch/unix/apr_arch_file_io.h
On 03.02.2010 11:18, pquerna@apache.org wrote:
> Author: pquerna
> Date: Wed Feb 3 10:17:57 2010
> New Revision: 905970
>
> URL: http://svn.apache.org/viewvc?rev=905970&view=rev
> Log:
> Add two new features to APR Files:
> - When opened with normal rotating flag, every 60 seconds the file will check
> if the file it is writing to has changed inode (ie, been replaced/moved).
> - When opened with the manual rotating flag, the consumer must call the check,
> but can provider the current timestamp, to avoid a apr_time call.
>
> This is based off of the patch from Brian, but I've modified it for style, and
> adding the manual rotation flag after discussion with brian at the httpd
> hackathon.
>
> Submitted by: Brian J. France <brian brianfrance.com>
>
> Modified:
> apr/apr/trunk/file_io/unix/filedup.c
> apr/apr/trunk/file_io/unix/open.c
> apr/apr/trunk/file_io/unix/readwrite.c
> apr/apr/trunk/include/apr_file_io.h
> apr/apr/trunk/include/arch/unix/apr_arch_file_io.h
This breaks compilation of httpd trunk:
server/.libs/libmain.a(exports.o):(.data+0x1540): undefined reference to
`apr_file_rotating_manual_check'
collect2: ld returned 1 exit status
make[1]: *** [httpd] Fehler 1
make: *** [all-recursive] Fehler 1
Regards
Rüdiger
Re: svn commit: r905970 - in /apr/apr/trunk: file_io/unix/filedup.c
file_io/unix/open.c file_io/unix/readwrite.c include/apr_file_io.h
include/arch/unix/apr_arch_file_io.h
Posted by Paul Querna <pa...@querna.org>.
On Wed, Feb 3, 2010 at 11:52 AM, Ruediger Pluem <rp...@apache.org> wrote:
> On 03.02.2010 20:45, Rüdiger Plüm wrote:
>> On 03.02.2010 11:18, pquerna@apache.org wrote:
>>> Author: pquerna
>>> Date: Wed Feb 3 10:17:57 2010
>>> New Revision: 905970
>>>
>>> URL: http://svn.apache.org/viewvc?rev=905970&view=rev
>>> Log:
>>> Add two new features to APR Files:
>>> - When opened with normal rotating flag, every 60 seconds the file will check
>>> if the file it is writing to has changed inode (ie, been replaced/moved).
>>> - When opened with the manual rotating flag, the consumer must call the check,
>>> but can provider the current timestamp, to avoid a apr_time call.
>>>
>>> This is based off of the patch from Brian, but I've modified it for style, and
>>> adding the manual rotation flag after discussion with brian at the httpd
>>> hackathon.
>>>
>>> Submitted by: Brian J. France <brian brianfrance.com>
>>>
>>> Modified:
>>> apr/apr/trunk/file_io/unix/filedup.c
>>> apr/apr/trunk/file_io/unix/open.c
>>> apr/apr/trunk/file_io/unix/readwrite.c
>>> apr/apr/trunk/include/apr_file_io.h
>>> apr/apr/trunk/include/arch/unix/apr_arch_file_io.h
>>
>> This breaks compilation of httpd trunk:
>>
>> server/.libs/libmain.a(exports.o):(.data+0x1540): undefined reference to
>> `apr_file_rotating_manual_check'
>> collect2: ld returned 1 exit status
>> make[1]: *** [httpd] Fehler 1
>> make: *** [all-recursive] Fehler 1
>
> Fixed in r906206.
>
D'oh, sorry about that, thanks for fixing it!
Re: svn commit: r905970 - in /apr/apr/trunk: file_io/unix/filedup.c
file_io/unix/open.c file_io/unix/readwrite.c include/apr_file_io.h include/arch/unix/apr_arch_file_io.h
Posted by Ruediger Pluem <rp...@apache.org>.
On 03.02.2010 20:45, Rüdiger Plüm wrote:
> On 03.02.2010 11:18, pquerna@apache.org wrote:
>> Author: pquerna
>> Date: Wed Feb 3 10:17:57 2010
>> New Revision: 905970
>>
>> URL: http://svn.apache.org/viewvc?rev=905970&view=rev
>> Log:
>> Add two new features to APR Files:
>> - When opened with normal rotating flag, every 60 seconds the file will check
>> if the file it is writing to has changed inode (ie, been replaced/moved).
>> - When opened with the manual rotating flag, the consumer must call the check,
>> but can provider the current timestamp, to avoid a apr_time call.
>>
>> This is based off of the patch from Brian, but I've modified it for style, and
>> adding the manual rotation flag after discussion with brian at the httpd
>> hackathon.
>>
>> Submitted by: Brian J. France <brian brianfrance.com>
>>
>> Modified:
>> apr/apr/trunk/file_io/unix/filedup.c
>> apr/apr/trunk/file_io/unix/open.c
>> apr/apr/trunk/file_io/unix/readwrite.c
>> apr/apr/trunk/include/apr_file_io.h
>> apr/apr/trunk/include/arch/unix/apr_arch_file_io.h
>
> This breaks compilation of httpd trunk:
>
> server/.libs/libmain.a(exports.o):(.data+0x1540): undefined reference to
> `apr_file_rotating_manual_check'
> collect2: ld returned 1 exit status
> make[1]: *** [httpd] Fehler 1
> make: *** [all-recursive] Fehler 1
Fixed in r906206.
Regards
Rüdiger