You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/05/25 20:48:45 UTC

[GitHub] [ozone] umamaheswararao commented on a diff in pull request #3453: HDDS-6795: EC: PipelineStateMap#addPipeline should not have precondition checks post db updates

umamaheswararao commented on code in PR #3453:
URL: https://github.com/apache/ozone/pull/3453#discussion_r882102833


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineStateMap.java:
##########
@@ -70,14 +70,6 @@ class PipelineStateMap {
    * @throws IOException if pipeline with provided pipelineID already exists
    */
   void addPipeline(Pipeline pipeline) throws IOException {
-    Preconditions.checkNotNull(pipeline, "Pipeline cannot be null");

Review Comment:
   I think it make sense to leave this preconditions as is. Anyway we are making sure to pass the correct pipeline with other checks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org