[jira] [Work logged] (GOBBLIN-1462) Ensure FsSpecConsumer handles config keys which are prefixes of other keys

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1462?focusedWorklogId=608848&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-608848 ]

ASF GitHub Bot logged work on GOBBLIN-1462:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Jun/21 00:43
            Start Date: 09/Jun/21 00:43
    Worklog Time Spent: 10m 
      Work Description: sv2000 opened a new pull request #3302:
URL: https://github.com/apache/gobblin/pull/3302


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1462
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   Currently, the FsSpecConsumer fails when building a JobSpec if the configuration contains keys which are prefixes of other keys, which is not allowed in typesafe config. In practice, this constraint may be violated particularly when loading system properties which are outside application's control. To ensure these properties are safely handled, the FsSpecConsumer should use the proertiesToConfig() method in PropertiesUtils which adds a suffix to the root properties.  
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Modified unit tests
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 608848)
    Remaining Estimate: 0h
            Time Spent: 10m

> Ensure FsSpecConsumer handles config keys which are prefixes of other keys
> --------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1462
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1462
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-cluster
>    Affects Versions: 0.15.0
>            Reporter: Sudarshan Vasudevan
>            Assignee: Sudarshan Vasudevan
>            Priority: Major
>             Fix For: 0.16.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, the FsSpecConsumer fails when building a JobSpec if the configuration contains keys which are prefixes of other keys, which is not allowed in typesafe config. In practice, this constraint may be violated particularly when loading system properties which are outside application's control. To ensure these properties are safely handled, the FsSpecConsumer should use the proertiesToConfig() method in PropertiesUtils which adds a suffix to the root properties.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)