You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "ppkarwasz (via GitHub)" <gi...@apache.org> on 2025/06/07 06:21:55 UTC
[PR] Improve reliability of reproducibility verification [logging-parent]
ppkarwasz opened a new pull request, #406:
URL: https://github.com/apache/logging-parent/pull/406
This change introduces a separate cache specifically for the `verify-reproducibility` workflow to ensure it does not reuse artifacts cached by other workflows. By isolating its cache, we ensure that reproducibility checks are based solely on artifacts built within the same workflow, improving the reliability and accuracy of the verification.
Closes #388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve reliability of reproducibility verification [logging-parent]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz merged PR #406:
URL: https://github.com/apache/logging-parent/pull/406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve reliability of reproducibility verification [logging-parent]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #406:
URL: https://github.com/apache/logging-parent/pull/406#discussion_r2133469530
##########
.github/workflows/verify-reproducibility-reusable.yaml:
##########
@@ -61,7 +61,30 @@ jobs:
with:
distribution: zulu
java-version: ${{ inputs.java-version }}
- cache: maven
+
+ #
+ # Generates a cache key prefix to enable partial cache hits.
+ # If there's no exact match for the full cache key, any cache with this prefix can be used as a fallback.
+ # To avoid unbounded cache growth, the prefix includes the current month,
+ # ensuring a new cache is started each month.
+ #
+ - name: Compute Cache Key Prefix
+ shell: bash
+ run: |
+ date +"CACHE_KEY=verify-reproducibility-%Y-%m" >> $GITHUB_ENV
+
+ #
+ # Configures caching for the local Maven repository.
+ # Uses a custom cache key to isolate artifacts built in this workflow,
+ # preventing reproducibility results from being affected by cached outputs from other workflows.
+ #
+ - name: Set up Maven Cache
+ uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684 # 4.2.3
Review Comment:
[nitpick] Pinning to a full commit SHA can hinder readability; consider using the official version tag (e.g., 'actions/cache@v3') to clarify intent and simplify future upgrades.
```suggestion
uses: actions/cache@v3 # 4.2.3
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve reliability of reproducibility verification [logging-parent]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #406:
URL: https://github.com/apache/logging-parent/pull/406#discussion_r2133472810
##########
.github/workflows/verify-reproducibility-reusable.yaml:
##########
@@ -61,7 +61,30 @@ jobs:
with:
distribution: zulu
java-version: ${{ inputs.java-version }}
- cache: maven
+
+ #
+ # Generates a cache key prefix to enable partial cache hits.
+ # If there's no exact match for the full cache key, any cache with this prefix can be used as a fallback.
+ # To avoid unbounded cache growth, the prefix includes the current month,
+ # ensuring a new cache is started each month.
+ #
+ - name: Compute Cache Key Prefix
+ shell: bash
+ run: |
+ date +"CACHE_KEY=verify-reproducibility-%Y-%m" >> $GITHUB_ENV
+
+ #
+ # Configures caching for the local Maven repository.
+ # Uses a custom cache key to isolate artifacts built in this workflow,
+ # preventing reproducibility results from being affected by cached outputs from other workflows.
+ #
+ - name: Set up Maven Cache
+ uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684 # 4.2.3
Review Comment:
The full SHA is the standard in this repo and there is a comment with the version number.
Besides, you are proposing to downgrade from 4.2.3 to 3.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org