You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "hudi-bot (via GitHub)" <gi...@apache.org> on 2025/11/30 13:57:38 UTC
[I] Move serde util methods from Util classes to HoodieTimeline [hudi]
hudi-bot opened a new issue, #17382:
URL: https://github.com/apache/hudi/issues/17382
Examples:
[https://github.com/apache/hudi/pull/12826#discussion_r1975935379]
[https://github.com/apache/hudi/pull/12826#discussion_r1975945948]
We should have all instant metadata serde methods in HoodieTimeline so it's easier to maintain.
## JIRA info
- Link: https://issues.apache.org/jira/browse/HUDI-9091
- Type: Sub-task
- Parent: https://issues.apache.org/jira/browse/HUDI-9054
- Fix version(s):
- 1.1.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Move serde util methods from Util classes to HoodieTimeline [hudi]
Posted by "rangareddy (via GitHub)" <gi...@apache.org>.
rangareddy commented on issue #17382:
URL: https://github.com/apache/hudi/issues/17382#issuecomment-5351241798
This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-9091).
**Findings: not done on `master`.**
The two review comments that created this ticket asked for the instant-metadata serde and accessor methods to be unified onto `HoodieTimeline`:
> "nit: We should merge these cleaner metadata utils to `HoodieTimeline` class. We can take that up in a follow-up PR with a new JIRA ticket." ([r1975935379](https://github.com/apache/hudi/pull/12826#discussion_r1975935379), on `CleanerUtils.java`)
> "Similarly, we should get rid of such util methods and unify them into the `HoodieTimeline` class or another so the code is easier to maintain." ([r1975945948](https://github.com/apache/hudi/pull/12826#discussion_r1975945948), on `ClusteringUtils.java`)
Both classes still hold them:
- `hudi-common/src/main/java/org/apache/hudi/common/util/CleanerUtils.java` - `convertCleanMetadata` (`:68`), `getCleanerMetadata` (`:109`, `:115`), `getCleanerPlan` (`:231`, `:246`), `getCleanRequestInstant` (`:239`)
- `hudi-common/src/main/java/org/apache/hudi/common/util/ClusteringUtils.java` - `getAllPendingClusteringPlans` (`:83`), `getClusteringPlan` (`:248`, `:271`, `:281`), `getPendingClusteringPlan` (`:258`)
Worth adding a third family to the scope while this is being done: `MetadataConversionUtils.convertCommitMetadataToAvro` (`hudi-common/src/main/java/org/apache/hudi/common/table/timeline/MetadataConversionUtils.java:374`) is the same kind of instant-metadata conversion helper, already living in the `timeline` package but not on `HoodieTimeline`. Consolidating cleaner and clustering while leaving that one behind would leave the maintenance problem half-solved.
Keeping this open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org