You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "wolflex888 (via GitHub)" <gi...@apache.org> on 2025/03/20 17:05:49 UTC
[PR] populate credentials field for loadTableResponse [polaris]
wolflex888 opened a new pull request, #1225:
URL: https://github.com/apache/polaris/pull/1225
<!--
Possible security vulnerabilities: STOP here and contact security@apache.org instead!
Please update the title of the PR with a meaningful message - do not leave it "empty" or "generated"
Please update this summary field:
The summary should cover these topics, if applicable:
* the motivation for the change
* a description of the status quo, for example the current behavior
* the desired behavior
* etc
PR checklist:
- Do a self-review of your code before opening a pull request
- Make sure that there's good test coverage for the changes included in this PR
- Run tests locally before pushing a PR (./gradlew check)
- Code should have comments where applicable. Particularly hard-to-understand
areas deserve good in-line documentation.
- Include changes and enhancements to the documentation (in site/content/in-dev/unreleased)
- For Work In Progress Pull Requests, please use the Draft PR feature.
Make sure to add the information BELOW this comment.
Everything in this comment will NOT be added to the PR description.
-->
Previously, we are not populating the `Credentials` field for `LoadTableResponse` and we are using that field to populate the result of `LoadCredentials` endpoint. This PR cleans up the code a bit and populate the configs and credentials.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] populate credentials field for loadTableResponse [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on PR #1225:
URL: https://github.com/apache/polaris/pull/1225#issuecomment-2767726844
Hey @wolflex888, can you check out the CI failures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] populate credentials field for loadTableResponse [polaris]
Posted by "wolflex888 (via GitHub)" <gi...@apache.org>.
wolflex888 commented on PR #1225:
URL: https://github.com/apache/polaris/pull/1225#issuecomment-2745403754
> I see @wolflex888, that makes sense. Can you confirm that for the same table, you see vended credentials though? Are they in the `config` or in `credentials`?
@eric-maynard Yes, The vended credentials only lives in config right now and iceberg uses that field in `loadTable` to initiate `tableSession` and `tableFileIO` as well. I am populating this field so our `loadCredentials` will work. AFAIK they are not using the credentials field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] populate credentials field for loadTableResponse [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on PR #1225:
URL: https://github.com/apache/polaris/pull/1225#issuecomment-2742347670
@wolflex888 can you share how you did that testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] populate credentials field for loadTableResponse [polaris]
Posted by "wolflex888 (via GitHub)" <gi...@apache.org>.
wolflex888 commented on PR #1225:
URL: https://github.com/apache/polaris/pull/1225#issuecomment-2795228852
@eric-maynard this is resolved!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] populate credentials field for loadTableResponse [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on PR #1225:
URL: https://github.com/apache/polaris/pull/1225#issuecomment-2741211488
I think we must populate it, right? Or else how does credential vending work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] populate credentials field for loadTableResponse [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard merged PR #1225:
URL: https://github.com/apache/polaris/pull/1225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] populate credentials field for loadTableResponse [polaris]
Posted by "wolflex888 (via GitHub)" <gi...@apache.org>.
wolflex888 commented on PR #1225:
URL: https://github.com/apache/polaris/pull/1225#issuecomment-2743607992
> @wolflex888 can you share how you did that testing?
We are running an instance within our organization and the endpoint `/credentials` was not returning any data. When we are tracking it down, we found out that credentials field is not being populated. Maybe, I missed something on the way. Did you see `credentials` field getting populated? Currently, I don't think [Iceberg](https://github.com/apache/iceberg/pull/12591/files) is using that field either, but i can be wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] populate credentials field for loadTableResponse [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on PR #1225:
URL: https://github.com/apache/polaris/pull/1225#issuecomment-2744336854
I see @wolflex888, that makes sense. Can you confirm that for the same table, you see vended credentials though? Are they in the `config` or in `credentials`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] populate credentials field for loadTableResponse [polaris]
Posted by "wolflex888 (via GitHub)" <gi...@apache.org>.
wolflex888 commented on PR #1225:
URL: https://github.com/apache/polaris/pull/1225#issuecomment-2742316614
> I think we must populate it, right? Or else how does credential vending work?
hmm when we were testing the endpoint, the endpoint was returning an empty array. that's why we want to put up a PR to fix it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org