[GitHub] [apisix] spacewander commented on a diff in pull request #7965: fix: use modifiedIndex ad lru key when merge plugins from route and …

[GitBox <gi...@apache.org>]

spacewander commented on code in PR #7965:
URL: https://github.com/apache/apisix/pull/7965#discussion_r977153385


##########
apisix/plugin.lua:
##########
@@ -655,7 +655,7 @@ function _M.merge_consumer_route(route_conf, consumer_conf, api_ctx)
     core.log.info("route conf: ", core.json.delay_encode(route_conf))
     core.log.info("consumer conf: ", core.json.delay_encode(consumer_conf))
 
-    local flag = tostring(route_conf) .. tostring(consumer_conf)
+    local flag = route_conf.modifiedIndex .. consumer_conf.modifiedIndex

Review Comment:
   We should use both id and the version (modifiedIndex)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org