You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "CodeWithEmad (via GitHub)" <gi...@apache.org> on 2024/07/12 21:34:15 UTC
[PR] feat: Persian translations [superset]
CodeWithEmad opened a new pull request, #29580:
URL: https://github.com/apache/superset/pull/29580
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #29580:
URL: https://github.com/apache/superset/pull/29580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "CodeWithEmad (via GitHub)" <gi...@apache.org>.
CodeWithEmad commented on PR #29580:
URL: https://github.com/apache/superset/pull/29580#issuecomment-2234582409
OMG. I'm so so sorry. It's working fine in the test env. There must be something wrong with my local setup. I'll close the issue, but keep this PR as a draft so I can add translations in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #29580:
URL: https://github.com/apache/superset/pull/29580#issuecomment-2226391188
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/29580?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 64.89%. Comparing base [(`76d897e`)](https://app.codecov.io/gh/apache/superset/commit/76d897eaa2f9e137102bc194c2e3109c29d0348f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`456afa3`)](https://app.codecov.io/gh/apache/superset/commit/456afa3e2e139aff5846d79cddb5dcd7a63b9d0b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 445 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #29580 +/- ##
==========================================
+ Coverage 60.48% 64.89% +4.40%
==========================================
Files 1931 524 -1407
Lines 76236 37775 -38461
Branches 8568 0 -8568
==========================================
- Hits 46114 24514 -21600
+ Misses 28017 13261 -14756
+ Partials 2105 0 -2105
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/29580/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/29580/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.13% <ø> (-0.04%)` | :arrow_down: |
| [javascript](https://app.codecov.io/gh/apache/superset/pull/29580/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/29580/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.71% <ø> (-0.10%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/29580/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.89% <ø> (+1.40%)` | :arrow_up: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/29580/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.79% <ø> (+2.16%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/29580?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #29580:
URL: https://github.com/apache/superset/pull/29580#issuecomment-2839223955
/korbit-review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #29580:
URL: https://github.com/apache/superset/pull/29580#issuecomment-2229998618
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29580:
URL: https://github.com/apache/superset/pull/29580#issuecomment-2234401707
@rusackas Ephemeral environment spinning up at http://34.220.159.126:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #29580:
URL: https://github.com/apache/superset/pull/29580#issuecomment-2633463881
I did a quick look on the .po files trying to make sure we're not loosing any translations as part of this PR. It seems either a lot of strings got orphaned since the last update (maybe due to code deprecations as part of the 5.0 breaking window) , or there may be something wrong happening in the process.
Didn't have time to go "forensics-level" on it, but worth digging in a bit deeper to try and validate that the orphaned strings should indeed be dropped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "request-info[bot] (via GitHub)" <gi...@apache.org>.
request-info[bot] commented on PR #29580:
URL: https://github.com/apache/superset/pull/29580#issuecomment-2226383813
We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the `title` or `description` empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "CodeWithEmad (via GitHub)" <gi...@apache.org>.
CodeWithEmad commented on code in PR #29580:
URL: https://github.com/apache/superset/pull/29580#discussion_r1681721958
##########
superset/config.py:
##########
@@ -370,6 +370,7 @@ def _try_json_readsha(filepath: str, length: int) -> str | None:
"en": {"flag": "us", "name": "English"},
"es": {"flag": "es", "name": "Spanish"},
"it": {"flag": "it", "name": "Italian"},
+ "fa": {"flag": "ir", "name": "Persian"},
Review Comment:
Done. You're right, I didn't check other lines.
Don't even mention it. Thanks for helping me out.
##########
superset/config.py:
##########
@@ -370,6 +370,7 @@ def _try_json_readsha(filepath: str, length: int) -> str | None:
"en": {"flag": "us", "name": "English"},
"es": {"flag": "es", "name": "Spanish"},
"it": {"flag": "it", "name": "Italian"},
+ "fa": {"flag": "ir", "name": "Persian"},
Review Comment:
Done. You're right, I didn't check other lines.
Don't even mention it. Thanks for helping me out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #29580:
URL: https://github.com/apache/superset/pull/29580#discussion_r1681403263
##########
superset/config.py:
##########
@@ -370,6 +370,7 @@ def _try_json_readsha(filepath: str, length: int) -> str | None:
"en": {"flag": "us", "name": "English"},
"es": {"flag": "es", "name": "Spanish"},
"it": {"flag": "it", "name": "Italian"},
+ "fa": {"flag": "ir", "name": "Persian"},
Review Comment:
It's good to add this here, but line 389 below disables this whole block. For testing purposes, you can add a few languages there and they should show up on the ephemeral/test environments on this PR.
Sorry I haven't had time to build/test this locally yet... I'm still hoping to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "CodeWithEmad (via GitHub)" <gi...@apache.org>.
CodeWithEmad commented on PR #29580:
URL: https://github.com/apache/superset/pull/29580#issuecomment-2428709683
Also, https://github.com/dpgaspar/Flask-AppBuilder/pull/2278 will add the Persian translations to the Flask AppBuilder project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "CodeWithEmad (via GitHub)" <gi...@apache.org>.
CodeWithEmad commented on PR #29580:
URL: https://github.com/apache/superset/pull/29580#issuecomment-2425980921
Hey @rusackas, could you please take a moment to review this when you have a chance? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "CodeWithEmad (via GitHub)" <gi...@apache.org>.
CodeWithEmad commented on PR #29580:
URL: https://github.com/apache/superset/pull/29580#issuecomment-2628810054
Hey folks. I've been resolving conflicts for a while now. Does anyone interested in reviewing this?
@rusackas @mistercrunch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "CodeWithEmad (via GitHub)" <gi...@apache.org>.
CodeWithEmad commented on PR #29580:
URL: https://github.com/apache/superset/pull/29580#issuecomment-2848764503
Thanks, @rusackas. If the superset needs a Persian reviewer for the translations, I'll be more than happy to be a part of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "CodeWithEmad (via GitHub)" <gi...@apache.org>.
CodeWithEmad commented on PR #29580:
URL: https://github.com/apache/superset/pull/29580#issuecomment-2839563364
Thanks for the review, @rusackas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #29580:
URL: https://github.com/apache/superset/pull/29580#issuecomment-2231316284
Oh... turning on the test language file in `config.py` _should_ work for this ephemeral environment testing (or local testing, I believe)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29580:
URL: https://github.com/apache/superset/pull/29580#issuecomment-2230007721
@rusackas Ephemeral environment spinning up at http://34.220.119.216:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "CodeWithEmad (via GitHub)" <gi...@apache.org>.
CodeWithEmad commented on PR #29580:
URL: https://github.com/apache/superset/pull/29580#issuecomment-2230767908
Fixed. I checked the test env (which is such a cool command!) but haven't seen the flags. in login. maybe I should add it somewhere else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #29580:
URL: https://github.com/apache/superset/pull/29580#issuecomment-2229991913
You can install and [run the pre-commit hook](https://superset.apache.org/docs/contributing/development/#git-hooks-1) to fix the linting errors. The SQLite test failure is probably unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "CodeWithEmad (via GitHub)" <gi...@apache.org>.
CodeWithEmad commented on PR #29580:
URL: https://github.com/apache/superset/pull/29580#issuecomment-2426421471
Wow! I didn't request for review from all of you, folks. looks like editing labeler.yml triggered something :))))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Persian translations [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #29580:
URL: https://github.com/apache/superset/pull/29580#issuecomment-2234379606
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org