You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwhisk.apache.org by Markus Thömmes <ma...@apache.org> on 2019/11/20 15:44:21 UTC
Road to Scala 2.13
Hey fellow Openwhiskers,
I somewhat fancy a little bit of Scala action and wanted to give updating
Openwhisk to Scala 2.13 a shot. They have reworked quite a bit in Scala
2.13 and keeping track with the versions might be very valuable, especially
if Dotty comes around eventually.
To pull that off, we'll need to bump quite a few libraries, some of them
even in their major version. I plan to send each of those major upgrades as
individual PRs, so we can pinpoint potential issues via git bisecting if
necessary.
kamon-statsd and rxscala are two libraries where there are no 2.13
artifacts published yet. RxScala meanwhile has support of 2.13 in its
repository, so we'd need to wait on a new release there. kamon-statsd has
an open issue to support 2.13, we might need to go ahead and nudge a bit
there, see https://github.com/kamon-io/kamon-statsd/issues/9. Do we even
need the statds integration anymore at this point? @Sven Lange-Last might
know.
We'll see if there are more dragons, but I'm happy to work through them to
some extent :). Is anybody concerned with doing this move in general and
with the process laid out specifically?
Cheers,
Markus
Re: Road to Scala 2.13
Posted by Rodric Rabbah <ro...@gmail.com>.
sounds great to me - thanks Markus for bringing this up.
-r
On Wed, Nov 20, 2019 at 7:44 AM Markus Thömmes <ma...@apache.org>
wrote:
> Hey fellow Openwhiskers,
>
> I somewhat fancy a little bit of Scala action and wanted to give updating
> Openwhisk to Scala 2.13 a shot. They have reworked quite a bit in Scala
> 2.13 and keeping track with the versions might be very valuable, especially
> if Dotty comes around eventually.
>
> To pull that off, we'll need to bump quite a few libraries, some of them
> even in their major version. I plan to send each of those major upgrades as
> individual PRs, so we can pinpoint potential issues via git bisecting if
> necessary.
>
> kamon-statsd and rxscala are two libraries where there are no 2.13
> artifacts published yet. RxScala meanwhile has support of 2.13 in its
> repository, so we'd need to wait on a new release there. kamon-statsd has
> an open issue to support 2.13, we might need to go ahead and nudge a bit
> there, see https://github.com/kamon-io/kamon-statsd/issues/9. Do we even
> need the statds integration anymore at this point? @Sven Lange-Last might
> know.
>
> We'll see if there are more dragons, but I'm happy to work through them to
> some extent :). Is anybody concerned with doing this move in general and
> with the process laid out specifically?
>
> Cheers,
> Markus
>
Re: Road to Scala 2.13
Posted by Chetan Mehrotra <ch...@gmail.com>.
+1 to move to 2.13.
Last time when we updated to 2.12 we had to update all modules also as the
Scala version is specified per module. And those changes had to be
coordinated
See https://github.com/apache/openwhisk/issues/3952 for link to changes
done in various module
Chetan Mehrotra
On Thu, Nov 21, 2019 at 12:33 PM Markus Thömmes <ma...@apache.org>
wrote:
> Am Mi., 20. Nov. 2019 um 19:52 Uhr schrieb David P Grove <
> groved@us.ibm.com
> >:
>
> >
> > "Markus Thömmes" <ma...@apache.org> wrote on 11/20/2019
> 10:44:21
> > AM:
> > >
> > > Hey fellow Openwhiskers,
> > >
> > > I somewhat fancy a little bit of Scala action and wanted to give
> updating
> > > Openwhisk to Scala 2.13 a shot. They have reworked quite a bit in Scala
> > > 2.13 and keeping track with the versions might be very valuable,
> > especially
> > > if Dotty comes around eventually.
> > >
> > > To pull that off, we'll need to bump quite a few libraries, some of
> them
> > > even in their major version. I plan to send each of those major
> upgrades
> > as
> > > individual PRs, so we can pinpoint potential issues via git bisecting
> if
> > > necessary.
> > ....
> > >
> > > We'll see if there are more dragons, but I'm happy to work through them
> > to
> > > some extent :). Is anybody concerned with doing this move in general
> and
> > > with the process laid out specifically?
> > >
> >
> > Generally sounds good; happy to have someone pushing on chasing language
> > versions :)
> >
> > One thing to be careful of is that many downstream repos (runtime,
> > providers) depend on the test suite from the core repo. We had a couple
> > rounds of breakage in the last few months where a test suite change got a
> > clean core travis run, but still broke all the downstream repos leading
> to
> > some hasty fixing and/or reverting.
> >
>
> I hear you! Is there a good way to verify stuff works across all
> repositories or will I have to manually go through all of them and check if
> my changes have any impact?
>
>
> >
> > -dave
> >
>
Re: Road to Scala 2.13
Posted by Markus Thömmes <ma...@apache.org>.
Hey all,
here's a set of potentially downstream breaking changes:
https://github.com/apache/openwhisk/pull/4736: Note how I changed "|
string" to "| lower" in the ansible scripts. Pureconfig seems to be more
picky when it comes to Boolean values and only allows "true" and "false"
there. Python usually produces "True" and "False", which caused things to
break.
https://github.com/apache/openwhisk/pull/4749: This updates the
akka-management parts of the system which potentially has an impact on
setups that use Kubernetes or Mesos API to build the controller cluster.
Am Do., 21. Nov. 2019 um 15:10 Uhr schrieb Carlos Santana <
csantana23@gmail.com>:
> Woot +1
>
> - Carlos Santana
> @csantanapr
>
> > On Nov 21, 2019, at 5:58 AM, David P Grove <gr...@us.ibm.com> wrote:
> >
> >
> >
> >
> > "Markus Thömmes" <ma...@apache.org> wrote on 11/21/2019
> 02:03:30
> > AM:
> >>>
> >>> One thing to be careful of is that many downstream repos (runtime,
> >>> providers) depend on the test suite from the core repo. We had a
> > couple
> >>> rounds of breakage in the last few months where a test suite change got
> > a
> >>> clean core travis run, but still broke all the downstream repos leading
> > to
> >>> some hasty fixing and/or reverting.
> >>>
> >>
> >> I hear you! Is there a good way to verify stuff works across all
> >> repositories or will I have to manually go through all of them and check
> > if
> >> my changes have any impact?
> >>
> >>
> >
> > Not going to be perfect, but I think all of the breakages we had would
> have
> > been caught by building even one downstream repo against the modified
> core
> > since the test suite is used more or less the same way in all the runtime
> > repos.
> >
> > --dave
>
Re: Road to Scala 2.13
Posted by Carlos Santana <cs...@gmail.com>.
Woot +1
- Carlos Santana
@csantanapr
> On Nov 21, 2019, at 5:58 AM, David P Grove <gr...@us.ibm.com> wrote:
>
>
>
>
> "Markus Thömmes" <ma...@apache.org> wrote on 11/21/2019 02:03:30
> AM:
>>>
>>> One thing to be careful of is that many downstream repos (runtime,
>>> providers) depend on the test suite from the core repo. We had a
> couple
>>> rounds of breakage in the last few months where a test suite change got
> a
>>> clean core travis run, but still broke all the downstream repos leading
> to
>>> some hasty fixing and/or reverting.
>>>
>>
>> I hear you! Is there a good way to verify stuff works across all
>> repositories or will I have to manually go through all of them and check
> if
>> my changes have any impact?
>>
>>
>
> Not going to be perfect, but I think all of the breakages we had would have
> been caught by building even one downstream repo against the modified core
> since the test suite is used more or less the same way in all the runtime
> repos.
>
> --dave
RE: Road to Scala 2.13
Posted by David P Grove <gr...@us.ibm.com>.
"Markus Thömmes" <ma...@apache.org> wrote on 11/21/2019 02:03:30
AM:
> >
> > One thing to be careful of is that many downstream repos (runtime,
> > providers) depend on the test suite from the core repo. We had a
couple
> > rounds of breakage in the last few months where a test suite change got
a
> > clean core travis run, but still broke all the downstream repos leading
to
> > some hasty fixing and/or reverting.
> >
>
> I hear you! Is there a good way to verify stuff works across all
> repositories or will I have to manually go through all of them and check
if
> my changes have any impact?
>
>
Not going to be perfect, but I think all of the breakages we had would have
been caught by building even one downstream repo against the modified core
since the test suite is used more or less the same way in all the runtime
repos.
--dave
Re: Road to Scala 2.13
Posted by Markus Thömmes <ma...@apache.org>.
Am Mi., 20. Nov. 2019 um 19:52 Uhr schrieb David P Grove <groved@us.ibm.com
>:
>
> "Markus Thömmes" <ma...@apache.org> wrote on 11/20/2019 10:44:21
> AM:
> >
> > Hey fellow Openwhiskers,
> >
> > I somewhat fancy a little bit of Scala action and wanted to give updating
> > Openwhisk to Scala 2.13 a shot. They have reworked quite a bit in Scala
> > 2.13 and keeping track with the versions might be very valuable,
> especially
> > if Dotty comes around eventually.
> >
> > To pull that off, we'll need to bump quite a few libraries, some of them
> > even in their major version. I plan to send each of those major upgrades
> as
> > individual PRs, so we can pinpoint potential issues via git bisecting if
> > necessary.
> ....
> >
> > We'll see if there are more dragons, but I'm happy to work through them
> to
> > some extent :). Is anybody concerned with doing this move in general and
> > with the process laid out specifically?
> >
>
> Generally sounds good; happy to have someone pushing on chasing language
> versions :)
>
> One thing to be careful of is that many downstream repos (runtime,
> providers) depend on the test suite from the core repo. We had a couple
> rounds of breakage in the last few months where a test suite change got a
> clean core travis run, but still broke all the downstream repos leading to
> some hasty fixing and/or reverting.
>
I hear you! Is there a good way to verify stuff works across all
repositories or will I have to manually go through all of them and check if
my changes have any impact?
>
> -dave
>
Re: Road to Scala 2.13
Posted by David P Grove <gr...@us.ibm.com>.
"Markus Thömmes" <ma...@apache.org> wrote on 11/20/2019 10:44:21
AM:
>
> Hey fellow Openwhiskers,
>
> I somewhat fancy a little bit of Scala action and wanted to give updating
> Openwhisk to Scala 2.13 a shot. They have reworked quite a bit in Scala
> 2.13 and keeping track with the versions might be very valuable,
especially
> if Dotty comes around eventually.
>
> To pull that off, we'll need to bump quite a few libraries, some of them
> even in their major version. I plan to send each of those major upgrades
as
> individual PRs, so we can pinpoint potential issues via git bisecting if
> necessary.
....
>
> We'll see if there are more dragons, but I'm happy to work through them
to
> some extent :). Is anybody concerned with doing this move in general and
> with the process laid out specifically?
>
Generally sounds good; happy to have someone pushing on chasing language
versions :)
One thing to be careful of is that many downstream repos (runtime,
providers) depend on the test suite from the core repo. We had a couple
rounds of breakage in the last few months where a test suite change got a
clean core travis run, but still broke all the downstream repos leading to
some hasty fixing and/or reverting.
-dave