You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/16 05:16:08 UTC
[GitHub] [doris] dutyu opened a new pull request, #15128: [Feature](export) Support cancel export statement
dutyu opened a new pull request, #15128:
URL: https://github.com/apache/doris/pull/15128
# Proposed changes
Issue Number: close #xxx
## Problem summary
Users can cancel a running/pending export job by using
`
CANCEL EXPORT [FROM db] WHERE [LABEL = "export_label" | LABEL like "label_pattern" | STATE = "PENDING/EXPORTING"]
`
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [x] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [x] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
I will modify relevant docs later.
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15128: [Feature](export) Support cancel export statement
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15128:
URL: https://github.com/apache/doris/pull/15128#issuecomment-1369459560
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #15128: [Feature](export) Support cancel export statement
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #15128:
URL: https://github.com/apache/doris/pull/15128#discussion_r1061506780
##########
fe/fe-core/src/main/java/org/apache/doris/load/ExportMgr.java:
##########
@@ -294,12 +351,12 @@ public void replayCreateExportJob(ExportJob job) {
}
public void replayUpdateJobState(long jobId, ExportJob.JobState newState) {
- writeLock();
+ readLock();
Review Comment:
Why change to read lock?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15128: [Feature](export) Support cancel export statement
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15128:
URL: https://github.com/apache/doris/pull/15128#issuecomment-1369459822
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #15128: [Feature](export) Support cancel export statement
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #15128:
URL: https://github.com/apache/doris/pull/15128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15128: [Feature](export) Support cancel export statement
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15128:
URL: https://github.com/apache/doris/pull/15128#issuecomment-1369459573
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15128: [Feature](export) Support cancel export statement
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15128:
URL: https://github.com/apache/doris/pull/15128#issuecomment-1354284631
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.43 seconds
load time: 431 seconds
storage size: 17123356879 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221216063313_clickbench_pr_64329.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dutyu commented on a diff in pull request #15128: [Feature](export) Support cancel export statement
Posted by "dutyu (via GitHub)" <gi...@apache.org>.
dutyu commented on code in PR #15128:
URL: https://github.com/apache/doris/pull/15128#discussion_r1086250497
##########
fe/fe-core/src/main/java/org/apache/doris/load/ExportMgr.java:
##########
@@ -294,12 +351,12 @@ public void replayCreateExportJob(ExportJob job) {
}
public void replayUpdateJobState(long jobId, ExportJob.JobState newState) {
- writeLock();
+ readLock();
Review Comment:
This lock is designed to protect `idToJob` and `labelToJobId`, `replayUpdateJobState` method just read from the `idToJob`, so use a read lock may be more reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15128: [Feature](export) Support cancel export statement
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15128:
URL: https://github.com/apache/doris/pull/15128#issuecomment-1369459786
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org