You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2022/05/13 07:06:24 UTC

[Impala-ASF-CR] Revert "IMPALA-9057: Disable test transactional insert events"

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18524


Change subject: Revert "IMPALA-9057: Disable test_transactional_insert_events"
......................................................................

Revert "IMPALA-9057: Disable test_transactional_insert_events"

This reverts commit a873289508dc4e80256718c9921be1e337d263d6.
After HIVE-25137 and IMPALA-10923, we are able to add back the test.

Change-Id: I369353c8bb9b5437c2f5c4d411fb05e2fd751b9b
---
M tests/metadata/test_event_processing.py
1 file changed, 0 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/18524/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I369353c8bb9b5437c2f5c4d411fb05e2fd751b9b
Gerrit-Change-Number: 18524
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] Revert "IMPALA-9057: Disable test transactional insert events"

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18524 )

Change subject: Revert "IMPALA-9057: Disable test_transactional_insert_events"
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I369353c8bb9b5437c2f5c4d411fb05e2fd751b9b
Gerrit-Change-Number: 18524
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 May 2022 22:30:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-9057: Disable test transactional insert events"

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18524 )

Change subject: Revert "IMPALA-9057: Disable test_transactional_insert_events"
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I369353c8bb9b5437c2f5c4d411fb05e2fd751b9b
Gerrit-Change-Number: 18524
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 May 2022 04:49:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-9057: Disable test transactional insert events"

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18524 )

Change subject: Revert "IMPALA-9057: Disable test_transactional_insert_events"
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I369353c8bb9b5437c2f5c4d411fb05e2fd751b9b
Gerrit-Change-Number: 18524
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 May 2022 06:58:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-9057: Disable test transactional insert events"

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18524 )

Change subject: Revert "IMPALA-9057: Disable test_transactional_insert_events"
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8149/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I369353c8bb9b5437c2f5c4d411fb05e2fd751b9b
Gerrit-Change-Number: 18524
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 May 2022 22:30:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-9057: Disable test transactional insert events"

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18524 )

Change subject: Revert "IMPALA-9057: Disable test_transactional_insert_events"
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8151/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I369353c8bb9b5437c2f5c4d411fb05e2fd751b9b
Gerrit-Change-Number: 18524
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 May 2022 04:49:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-9057: Disable test transactional insert events"

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18524 )

Change subject: Revert "IMPALA-9057: Disable test_transactional_insert_events"
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8149/


-- 
To view, visit http://gerrit.cloudera.org:8080/18524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I369353c8bb9b5437c2f5c4d411fb05e2fd751b9b
Gerrit-Change-Number: 18524
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 May 2022 03:00:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-9057: Disable test transactional insert events"

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18524 )

Change subject: Revert "IMPALA-9057: Disable test_transactional_insert_events"
......................................................................


Patch Set 2:

> Patch Set 2: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8149/

The failure is due to IMPALA-11160


-- 
To view, visit http://gerrit.cloudera.org:8080/18524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I369353c8bb9b5437c2f5c4d411fb05e2fd751b9b
Gerrit-Change-Number: 18524
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 May 2022 04:49:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-9057: Disable test transactional insert events"

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18524 )

Change subject: Revert "IMPALA-9057: Disable test_transactional_insert_events"
......................................................................


Patch Set 1:

Verified in two jobs:
https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/16440
https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/5662/


-- 
To view, visit http://gerrit.cloudera.org:8080/18524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I369353c8bb9b5437c2f5c4d411fb05e2fd751b9b
Gerrit-Change-Number: 18524
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 May 2022 12:43:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-9057: Disable test transactional insert events"

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18524 )

Change subject: Revert "IMPALA-9057: Disable test_transactional_insert_events"
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I369353c8bb9b5437c2f5c4d411fb05e2fd751b9b
Gerrit-Change-Number: 18524
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 May 2022 09:15:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-9057: Disable test transactional insert events"

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18524 )

Change subject: Revert "IMPALA-9057: Disable test_transactional_insert_events"
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10569/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I369353c8bb9b5437c2f5c4d411fb05e2fd751b9b
Gerrit-Change-Number: 18524
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 May 2022 07:26:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-9057: Disable test transactional insert events"

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18524 )

Change subject: Revert "IMPALA-9057: Disable test_transactional_insert_events"
......................................................................

Revert "IMPALA-9057: Disable test_transactional_insert_events"

This reverts commit a873289508dc4e80256718c9921be1e337d263d6.
After HIVE-25137 and IMPALA-10923, we are able to add back the test.

Change-Id: I369353c8bb9b5437c2f5c4d411fb05e2fd751b9b
Reviewed-on: http://gerrit.cloudera.org:8080/18524
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/metadata/test_event_processing.py
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I369353c8bb9b5437c2f5c4d411fb05e2fd751b9b
Gerrit-Change-Number: 18524
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>