You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/02 02:50:23 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new issue #15730: [OpenForce 2022] Add SQL parser test case for `StopScalingStatement`
RaigorJiang opened a new issue #15730:
URL: https://github.com/apache/shardingsphere/issues/15730
Hi community,
This issue is for [OpenForce 2022](https://github.com/apache/shardingsphere/discussions/12683#discussioncomment-2139441)
### Background
`STOP SCALING jobId` is a syntax in [DistSQL RAL](https://shardingsphere.apache.org/document/current/en/user-manual/shardingsphere-proxy/distsql/syntax/ral/), when `ShardingSphereSQLParserEngine` receives this SQL text, it parses it as `ShowScalingStatusStatement`. Now we need to add a test case for this parsing process to assert that its parsing is correct.
### Aim
Add SQL parser test case for `StopScalingStatement`.
- Affected files:
- `SQLParserTestCases` (modify)
- `shardingsphere-test/shardingsphere-parser-test/src/main/resources/case/ral/update.xml` (modify)
- `shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported/ral/update.xml` (modify)
- `shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/statement/distsql/ral/scaling/StopScalingTestCase.java` (create )
- `shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/scaling/update/StopScalingStatementAssert.java` (create )
- `UpdatableScalingRALStatementAssert` (modify)
- After all, execute `DistSQLParserParameterizedTest#assertDistSQL()` for validation
### Basic Qualifications
- Java
- Maven
### Example FYI
- `ApplyScalingStatement`
- `ApplyScalingStatementTestCase`
- `ApplyScalingStatementAssert`
- search for "apply-scaling"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang closed issue #15730: [OpenForce 2022] Add SQL parser test case for `StopScalingStatement`
Posted by GitBox <gi...@apache.org>.
RaigorJiang closed issue #15730:
URL: https://github.com/apache/shardingsphere/issues/15730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] pparthenhs commented on issue #15730: [OpenForce 2022] Add SQL parser test case for `StopScalingStatement`
Posted by GitBox <gi...@apache.org>.
pparthenhs commented on issue #15730:
URL: https://github.com/apache/shardingsphere/issues/15730#issuecomment-1062615238
Hello @RaigorJiang, I start working on this ticket. I will inform you when is ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #15730: [OpenForce 2022] Add SQL parser test case for `StopScalingStatement`
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #15730:
URL: https://github.com/apache/shardingsphere/issues/15730#issuecomment-1062716897
Hi @pparthenhs
It's OK, let's wait for CI to finish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] pparthenhs commented on issue #15730: [OpenForce 2022] Add SQL parser test case for `StopScalingStatement`
Posted by GitBox <gi...@apache.org>.
pparthenhs commented on issue #15730:
URL: https://github.com/apache/shardingsphere/issues/15730#issuecomment-1062669767
Hello @RaigorJiang , the issue is ready. Please let me know of any code review comments.
Best regards,
Panagiotis Parthenis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org