[GitHub] eric-haibin-lin commented on a change in pull request #8207: Fix segfaults in and tests for distributed kvstore

[gi...@git.apache.org]

eric-haibin-lin commented on a change in pull request #8207: Fix segfaults in and tests for distributed kvstore
URL: https://github.com/apache/incubator-mxnet/pull/8207#discussion_r143812683
 
 

 ##########
 File path: src/kvstore/kvstore_dist.h
 ##########
 @@ -237,7 +237,8 @@ class KVStoreDist : public KVStoreLocal {
       // TODO(haibin) refactor this for loop
       for (size_t i = 0; i < num_vals; i++) {
         auto &row_id = target_val_rowids[i].second;
-        NDArray indices = row_id.Copy(pinned_ctx_);
+        NDArray indices(row_id.shape(), pinned_ctx_, false, mshadow::kInt64);
 
 Review comment:
   This makes sure rsp_pull(val, rowid) can accept rowid with dtype other than int64.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services