[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #578: [#580] chore: add a standalone workflow for deploy/kubernetes

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102407636


##########
.github/workflows/build.yml:
##########
@@ -64,3 +64,9 @@ jobs:
     with:
       maven-args: package
       reports-path: "**/target/surefire-reports/*.txt"
+
+  deploy:
+    uses: ./.github/workflows/deploy.yml
+    with:
+      maven-args: package
+      maven-options: -DskipUTs -DskipITs

Review Comment:
   > There might be `deploy/YARN` in the future. Let's keep it as is now? If you wish to not run it with maven, feel free to change it later.
   
   I like the idea that we can simply call maven to build all the stuff. I am not intended to run without mvn.
   I'am thinking about this case.
   ```
   # for k8s
   mvn -Pk8s -DskipUTs -DskipITs
   
   # for yarn, it should be without -DskipUTs.
   mvn -Pyarn
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org