You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/30 00:16:09 UTC

[PR] Default SQL Federation provider to NONE [shardingsphere]

terrymanu opened a new pull request, #40007:
URL: https://github.com/apache/shardingsphere/pull/40007

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Default SQL Federation provider to NONE [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #40007:
URL: https://github.com/apache/shardingsphere/pull/40007


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Default SQL Federation provider to NONE [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #40007:
URL: https://github.com/apache/shardingsphere/pull/40007#issuecomment-5901535627

   ### Result
   
   **Review Result: Mergeable**
   
   SQL Federation now selects NONE when `providerType` is unspecified. The factory uses `findService`, so an explicitly specified unknown type still throws the full `SPI-00001` error. The duplicate type check remains unchanged.
   
   ### Evidence
   
   - All 43 targeted tests across the four affected modules passed.
   - Both in-memory H2 tests in the E2E driver passed, covering the actual query path with CALCITE explicitly selected.
   - Spotless and Checkstyle passed for all 10 changed Java files. Each of the 20 changed E2E YAML files only adds an explicit CALCITE provider.
   - `git diff --check` reported three newly indented blank lines. These match the repository’s Spotless formatting and were not treated as code issues.
   
   ### Coverage
   
   This is a standalone local change based on `8f51d818efa`. All 39 changed files were reviewed, including provider selection, rules and DistSQL, test configuration, and documentation. Existing configurations that omit `providerType` will switch from CALCITE to NONE; configurations that need to continue using SQL Federation must explicitly specify CALCITE. The full E2E suite requiring external services was not run. This conclusion covers local code only; CI was not reviewed. No review issues remain unresolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org