[GitHub] [spark] linhongliu-db commented on a change in pull request #30666: [SPARK-33142][SPARK-33647][SQL][FOLLOW-UP] code clean and more test cases

[GitBox <gi...@apache.org>]

linhongliu-db commented on a change in pull request #30666:
URL: https://github.com/apache/spark/pull/30666#discussion_r538183678



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -1484,16 +1514,37 @@ class SessionCatalog(
   def lookupFunction(
       name: FunctionIdentifier,
       children: Seq[Expression]): Expression = synchronized {
+
     // Note: the implementation of this function is a little bit convoluted.
     // We probably shouldn't use a single FunctionRegistry to register all three kinds of functions
     // (built-in, temp, and external).
     if (name.database.isEmpty && functionRegistry.functionExists(name)) {
-      // This function has been already loaded into the function registry.
-      return functionRegistry.lookupFunction(name, children)

Review comment:
       Below changes will be removed after https://github.com/apache/spark/pull/30662 is merged




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org