You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by babokim <gi...@git.apache.org> on 2014/07/17 15:44:45 UTC
[GitHub] tajo pull request: TAJO-955: Add database selection submit button ...
GitHub user babokim opened a pull request:
https://github.com/apache/tajo/pull/80
TAJO-955: Add database selection submit button in catalogview.jsp for text based browse.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/babokim/tajo TAJO-955
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/80.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #80
----
commit b4b5e9ba5fa7deda012944f4c7545d316dd969b9
Author: 김형준 <ba...@babokim-mbp.server.gruter.com>
Date: 2014-07-17T13:29:36Z
TAJO-955: Add database selection submit button in catalogview.jsp for text based browse.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-955: Add database selection submit button ...
Posted by babokim <gi...@git.apache.org>.
Github user babokim closed the pull request at:
https://github.com/apache/tajo/pull/80
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-955: Add database selection submit button ...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/80#issuecomment-49387616
Hi Hyoungjun.
This issue makes sense for text-based browsers, but the submit button is useless in graphical browsers. How about enforce pushing the submit button to change the database selection?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-955: Add database selection submit button ...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/80#issuecomment-49545679
I don't think that we SHOULD keep on-change event. Why do we have an obligation of adding a button which will be useless for most users?
I think that it can be our choice, and the above comment was just my suggestion.
If you guys don't agree, the current patch is also good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-955: Add database selection submit button ...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/80#issuecomment-49545812
I forgot +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-955: Add database selection submit button ...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/80#issuecomment-49546925
Thank you for your understanding.
@babokim Could you close this issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-955: Add database selection submit button ...
Posted by babokim <gi...@git.apache.org>.
Github user babokim commented on the pull request:
https://github.com/apache/tajo/pull/80#issuecomment-49406217
Hi jihoonson.
I use a elinks browser and this browser does not support a onchange javascript event. This is why I added the button. Do you means removing onchange event from selection component?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-955: Add database selection submit button ...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/80#issuecomment-49544500
In my opinion, the current approach using on-change event is also good. It is definitely convenient for users. Because only a few of users who use some web browsers which does not support java script will use submit button, we should kept on-change event for most of users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-955: Add database selection submit button ...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/80#issuecomment-49542418
Right. In my opinion, it will give users the consistent experience regardless of the browser type.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---