You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/28 23:59:06 UTC
[GitHub] [airflow] potiuk opened a new pull request #15064: Merge Quarantined tests with other tests
potiuk opened a new pull request #15064:
URL: https://github.com/apache/airflow/pull/15064
With the build parallelisation it is fine now to merge the
quarantined tests back into other tests.
This has low risk (Quarantined tests will not block other tests,
at most they will cause EXIT 137 if they use too much memory, but
this should be a rare event.
Merging the Quarantined tests back will decrease the pressure
on the number of jobs run on CI and will use more of
the parallelism we have for both self-hosted runners and
public runners.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #15064: Merge Quarantined tests with other tests
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #15064:
URL: https://github.com/apache/airflow/pull/15064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15064: Merge Quarantined tests with other tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15064:
URL: https://github.com/apache/airflow/pull/15064#issuecomment-809784771
AAh no. I realized it is a bad idea. Quarantine tests in this case run for all variants, which makes little sense. I will leave it as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15064: Merge Quarantined tests with other tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15064:
URL: https://github.com/apache/airflow/pull/15064#issuecomment-809546649
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15064: Merge Quarantined tests with other tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15064:
URL: https://github.com/apache/airflow/pull/15064#issuecomment-809464955
Would love to get that one merged for even snappier tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org