You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yuqi Du (Code Review)" <ge...@cloudera.org> on 2022/04/20 10:03:06 UTC
[kudu-CR] [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
Yuqi Du has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18431
Change subject: [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
......................................................................
[unit test] KUDU-3361 Fix SocketTest.TestRecvReset
SocketTest.TestRecvReset running not steady, and can cause the whole
jenkins task rerun. Using a fixed timeout parameter is not good
enough.
eg: 1ms coredump happened.
Check failure stack trace: ***
Aborted at 1650445865 (unix time) try "date -d @1650445865" if you are
using GNU date ***
PC: @ 0x7fd63d0092e7 __GI_raise
SIGABRT (@0x198309) received by PID 1671945 (TID 0x7fd640cb7980) from
PID 1671945; stack trace: ***
@ 0x7fd63e8881d1 google::(anonymous namespace)::FailureSignalHandler()
@ 0x7fd63d390140 (unknown)
@ 0x7fd63d0092e7 __GI_raise
@ 0x7fd63d00a6c8 __GI_abort
@ 0x7fd63e878419 google::logging_fail()
@ 0x7fd63e87be9d google::LogMessage::Fail()
@ 0x7fd63e87daae google::LogMessage::SendToLog()
@ 0x7fd63e87ba20 google::LogMessage::Flush()
@ 0x7fd63e87e399 google::LogMessageFatal::~LogMessageFatal()
@ 0x21ff23 kudu::SocketTest::ConnectToListeningServer()
@ 0x21cc4a kudu::SocketTest::DoTestServerDisconnects()
@ 0x21b29c kudu::SocketTest_TestRecvReset_Test::TestBody()
@ 0x7fd63e219f2e testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x7fd63e20fa2b testing::Test::Run()
@ 0x7fd63e20fb95 testing::TestInfo::Run()
@ 0x7fd63e20fc85 testing::TestSuite::Run()
@ 0x7fd63e210144 testing::internal::UnitTestImpl::RunAllTests()
@ 0x7fd63e21a46e testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x7fd63e210340 testing::UnitTest::Run()
@ 0x7fd640e933c1 RUN_ALL_TESTS()
@ 0x7fd640e92316 main
@ 0x7fd63cff5ac5 __libc_start_main
@ 0x219029 (unknown)
Aborted (core dumped)
eg:50ms test failed.
Value of: s.message().ToString()
Expected: contains regular expression "recv error from
127.0.0.1:[0-9]+: Resource temporarily unavailable"
Actual: "recv error from unknown peer: Transport endpoint is not
connected" (of type std::string)
WARNING: Logging before InitGoogleLogging() is written to STDERR
Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
---
M src/kudu/util/net/socket-test.cc
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/18431/1
--
To view, visit http://gerrit.cloudera.org:8080/18431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
Gerrit-Change-Number: 18431
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
[kudu-CR] [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18431 )
Change subject: [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18431/3/src/kudu/util/net/socket-test.cc
File src/kudu/util/net/socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/18431/3/src/kudu/util/net/socket-test.cc@127
PS3, Line 127: std::thread t([&]{
How about use kudu::Thread?
--
To view, visit http://gerrit.cloudera.org:8080/18431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
Gerrit-Change-Number: 18431
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sun, 24 Apr 2022 07:18:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18431 )
Change subject: [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Thank you for the fix! The current approach is much better than the prior one which relied on some timing (that might be still a bit flaky due to various scheduling anomalies).
http://gerrit.cloudera.org:8080/#/c/18431/3/src/kudu/util/net/socket-test.cc
File src/kudu/util/net/socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/18431/3/src/kudu/util/net/socket-test.cc@127
PS3, Line 127: void DoTestServerDisconnects(bool accept, const std::string &message) {
> Done
OK, it seems I made a typo (would -- would not): I meant using std::thread is totally fine in here. I apologize for the mis-typing.
Anyways, since you have already did the change, that's totally fine -- using kudu::Thread is also a way to go.
--
To view, visit http://gerrit.cloudera.org:8080/18431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
Gerrit-Change-Number: 18431
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 26 Apr 2022 16:50:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18431 )
Change subject: [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
......................................................................
[unit test] KUDU-3361 Fix SocketTest.TestRecvReset
The case SocketTest.TestRecvReset is not steady, and can cause
jenkins -1, and need rerun it. And I found using a fixed timeout
parameter is not good enough.
eg: Set timeout 1ms coredump happened.
Check failure stack trace: ***
Aborted at 1650445865 (unix time) try "date -d @1650445865" if you are
using GNU date ***
PC: @ 0x7fd63d0092e7 __GI_raise
SIGABRT (@0x198309) received by PID 1671945 (TID 0x7fd640cb7980) from
PID 1671945; stack trace: ***
@ 0x7fd63e8881d1 google::(anonymous namespace)::FailureSignalHandler()
@ 0x7fd63d390140 (unknown)
@ 0x7fd63d0092e7 __GI_raise
@ 0x7fd63d00a6c8 __GI_abort
@ 0x7fd63e878419 google::logging_fail()
@ 0x7fd63e87be9d google::LogMessage::Fail()
@ 0x7fd63e87daae google::LogMessage::SendToLog()
@ 0x7fd63e87ba20 google::LogMessage::Flush()
@ 0x7fd63e87e399 google::LogMessageFatal::~LogMessageFatal()
@ 0x21ff23 kudu::SocketTest::ConnectToListeningServer()
@ 0x21cc4a kudu::SocketTest::DoTestServerDisconnects()
@ 0x21b29c kudu::SocketTest_TestRecvReset_Test::TestBody()
@ 0x7fd63e219f2e testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x7fd63e20fa2b testing::Test::Run()
@ 0x7fd63e20fb95 testing::TestInfo::Run()
@ 0x7fd63e20fc85 testing::TestSuite::Run()
@ 0x7fd63e210144 testing::internal::UnitTestImpl::RunAllTests()
@ 0x7fd63e21a46e testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x7fd63e210340 testing::UnitTest::Run()
@ 0x7fd640e933c1 RUN_ALL_TESTS()
@ 0x7fd640e92316 main
@ 0x7fd63cff5ac5 __libc_start_main
@ 0x219029 (unknown)
Aborted (core dumped)
eg: Set timeout 50ms test failed.
Value of: s.message().ToString()
Expected: contains regular expression "recv error from
127.0.0.1:[0-9]+: Resource temporarily unavailable"
Actual: "recv error from unknown peer: Transport endpoint is not
connected" (of type std::string)
WARNING: Logging before InitGoogleLogging() is written to STDERR
Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
Reviewed-on: http://gerrit.cloudera.org:8080/18431
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/util/net/socket-test.cc
1 file changed, 15 insertions(+), 4 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
Gerrit-Change-Number: 18431
Gerrit-PatchSet: 6
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18431
to look at the new patch set (#3).
Change subject: [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
......................................................................
[unit test] KUDU-3361 Fix SocketTest.TestRecvReset
The case SocketTest.TestRecvReset is not steady, and can cause
jenkins -1, and need rerun it. And I found using a fixed timeout
parameter is not good enough.
eg: Set timeout 1ms coredump happened.
Check failure stack trace: ***
Aborted at 1650445865 (unix time) try "date -d @1650445865" if you are
using GNU date ***
PC: @ 0x7fd63d0092e7 __GI_raise
SIGABRT (@0x198309) received by PID 1671945 (TID 0x7fd640cb7980) from
PID 1671945; stack trace: ***
@ 0x7fd63e8881d1 google::(anonymous namespace)::FailureSignalHandler()
@ 0x7fd63d390140 (unknown)
@ 0x7fd63d0092e7 __GI_raise
@ 0x7fd63d00a6c8 __GI_abort
@ 0x7fd63e878419 google::logging_fail()
@ 0x7fd63e87be9d google::LogMessage::Fail()
@ 0x7fd63e87daae google::LogMessage::SendToLog()
@ 0x7fd63e87ba20 google::LogMessage::Flush()
@ 0x7fd63e87e399 google::LogMessageFatal::~LogMessageFatal()
@ 0x21ff23 kudu::SocketTest::ConnectToListeningServer()
@ 0x21cc4a kudu::SocketTest::DoTestServerDisconnects()
@ 0x21b29c kudu::SocketTest_TestRecvReset_Test::TestBody()
@ 0x7fd63e219f2e testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x7fd63e20fa2b testing::Test::Run()
@ 0x7fd63e20fb95 testing::TestInfo::Run()
@ 0x7fd63e20fc85 testing::TestSuite::Run()
@ 0x7fd63e210144 testing::internal::UnitTestImpl::RunAllTests()
@ 0x7fd63e21a46e testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x7fd63e210340 testing::UnitTest::Run()
@ 0x7fd640e933c1 RUN_ALL_TESTS()
@ 0x7fd640e92316 main
@ 0x7fd63cff5ac5 __libc_start_main
@ 0x219029 (unknown)
Aborted (core dumped)
eg: Set timeout 50ms test failed.
Value of: s.message().ToString()
Expected: contains regular expression "recv error from
127.0.0.1:[0-9]+: Resource temporarily unavailable"
Actual: "recv error from unknown peer: Transport endpoint is not
connected" (of type std::string)
WARNING: Logging before InitGoogleLogging() is written to STDERR
Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
---
M src/kudu/util/net/socket-test.cc
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/18431/3
--
To view, visit http://gerrit.cloudera.org:8080/18431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
Gerrit-Change-Number: 18431
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18431 )
Change subject: [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
......................................................................
Patch Set 6:
> Patch Set 5: Code-Review+2
>
> (1 comment)
>
> Thank you for the fix! The current approach is much better than the prior one which relied on some timing (that might be still a bit flaky due to various scheduling anomalies).
Thank you. You are very kind.
--
To view, visit http://gerrit.cloudera.org:8080/18431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
Gerrit-Change-Number: 18431
Gerrit-PatchSet: 6
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 27 Apr 2022 02:57:00 +0000
Gerrit-HasComments: No
[kudu-CR] [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18431
to look at the new patch set (#5).
Change subject: [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
......................................................................
[unit test] KUDU-3361 Fix SocketTest.TestRecvReset
The case SocketTest.TestRecvReset is not steady, and can cause
jenkins -1, and need rerun it. And I found using a fixed timeout
parameter is not good enough.
eg: Set timeout 1ms coredump happened.
Check failure stack trace: ***
Aborted at 1650445865 (unix time) try "date -d @1650445865" if you are
using GNU date ***
PC: @ 0x7fd63d0092e7 __GI_raise
SIGABRT (@0x198309) received by PID 1671945 (TID 0x7fd640cb7980) from
PID 1671945; stack trace: ***
@ 0x7fd63e8881d1 google::(anonymous namespace)::FailureSignalHandler()
@ 0x7fd63d390140 (unknown)
@ 0x7fd63d0092e7 __GI_raise
@ 0x7fd63d00a6c8 __GI_abort
@ 0x7fd63e878419 google::logging_fail()
@ 0x7fd63e87be9d google::LogMessage::Fail()
@ 0x7fd63e87daae google::LogMessage::SendToLog()
@ 0x7fd63e87ba20 google::LogMessage::Flush()
@ 0x7fd63e87e399 google::LogMessageFatal::~LogMessageFatal()
@ 0x21ff23 kudu::SocketTest::ConnectToListeningServer()
@ 0x21cc4a kudu::SocketTest::DoTestServerDisconnects()
@ 0x21b29c kudu::SocketTest_TestRecvReset_Test::TestBody()
@ 0x7fd63e219f2e testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x7fd63e20fa2b testing::Test::Run()
@ 0x7fd63e20fb95 testing::TestInfo::Run()
@ 0x7fd63e20fc85 testing::TestSuite::Run()
@ 0x7fd63e210144 testing::internal::UnitTestImpl::RunAllTests()
@ 0x7fd63e21a46e testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x7fd63e210340 testing::UnitTest::Run()
@ 0x7fd640e933c1 RUN_ALL_TESTS()
@ 0x7fd640e92316 main
@ 0x7fd63cff5ac5 __libc_start_main
@ 0x219029 (unknown)
Aborted (core dumped)
eg: Set timeout 50ms test failed.
Value of: s.message().ToString()
Expected: contains regular expression "recv error from
127.0.0.1:[0-9]+: Resource temporarily unavailable"
Actual: "recv error from unknown peer: Transport endpoint is not
connected" (of type std::string)
WARNING: Logging before InitGoogleLogging() is written to STDERR
Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
---
M src/kudu/util/net/socket-test.cc
1 file changed, 15 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/18431/5
--
To view, visit http://gerrit.cloudera.org:8080/18431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
Gerrit-Change-Number: 18431
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18431 )
Change subject: [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18431/3/src/kudu/util/net/socket-test.cc
File src/kudu/util/net/socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/18431/3/src/kudu/util/net/socket-test.cc@127
PS3, Line 127: std::thread t([&]{
> How about use kudu::Thread?
I guess eventually we want to use std::thread everywhere in Kudu code, so I would advocate to switching to kudu::Thread.
http://gerrit.cloudera.org:8080/#/c/18431/3/src/kudu/util/net/socket-test.cc@136
PS3, Line 136: SleepFor(MonoDelta::FromMilliseconds(10));
What's the reason to have this extra wait interval? Please add a comment to explain, or remove it if it's not needed.
--
To view, visit http://gerrit.cloudera.org:8080/18431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
Gerrit-Change-Number: 18431
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 25 Apr 2022 18:29:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18431
to look at the new patch set (#2).
Change subject: [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
......................................................................
[unit test] KUDU-3361 Fix SocketTest.TestRecvReset
SocketTest.TestRecvReset running not steady, and can cause the whole
jenkins task rerun. Using a fixed timeout parameter is not good
enough.
eg: 1ms coredump happened.
Check failure stack trace: ***
Aborted at 1650445865 (unix time) try "date -d @1650445865" if you are
using GNU date ***
PC: @ 0x7fd63d0092e7 __GI_raise
SIGABRT (@0x198309) received by PID 1671945 (TID 0x7fd640cb7980) from
PID 1671945; stack trace: ***
@ 0x7fd63e8881d1 google::(anonymous namespace)::FailureSignalHandler()
@ 0x7fd63d390140 (unknown)
@ 0x7fd63d0092e7 __GI_raise
@ 0x7fd63d00a6c8 __GI_abort
@ 0x7fd63e878419 google::logging_fail()
@ 0x7fd63e87be9d google::LogMessage::Fail()
@ 0x7fd63e87daae google::LogMessage::SendToLog()
@ 0x7fd63e87ba20 google::LogMessage::Flush()
@ 0x7fd63e87e399 google::LogMessageFatal::~LogMessageFatal()
@ 0x21ff23 kudu::SocketTest::ConnectToListeningServer()
@ 0x21cc4a kudu::SocketTest::DoTestServerDisconnects()
@ 0x21b29c kudu::SocketTest_TestRecvReset_Test::TestBody()
@ 0x7fd63e219f2e testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x7fd63e20fa2b testing::Test::Run()
@ 0x7fd63e20fb95 testing::TestInfo::Run()
@ 0x7fd63e20fc85 testing::TestSuite::Run()
@ 0x7fd63e210144 testing::internal::UnitTestImpl::RunAllTests()
@ 0x7fd63e21a46e testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x7fd63e210340 testing::UnitTest::Run()
@ 0x7fd640e933c1 RUN_ALL_TESTS()
@ 0x7fd640e92316 main
@ 0x7fd63cff5ac5 __libc_start_main
@ 0x219029 (unknown)
Aborted (core dumped)
eg:50ms test failed.
Value of: s.message().ToString()
Expected: contains regular expression "recv error from
127.0.0.1:[0-9]+: Resource temporarily unavailable"
Actual: "recv error from unknown peer: Transport endpoint is not
connected" (of type std::string)
WARNING: Logging before InitGoogleLogging() is written to STDERR
Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
---
M src/kudu/util/net/socket-test.cc
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/18431/2
--
To view, visit http://gerrit.cloudera.org:8080/18431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
Gerrit-Change-Number: 18431
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18431 )
Change subject: [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
......................................................................
Patch Set 4:
> Patch Set 3:
>
> (1 comment)
done
--
To view, visit http://gerrit.cloudera.org:8080/18431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
Gerrit-Change-Number: 18431
Gerrit-PatchSet: 4
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 26 Apr 2022 10:00:22 +0000
Gerrit-HasComments: No
[kudu-CR] [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18431
to look at the new patch set (#4).
Change subject: [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
......................................................................
[unit test] KUDU-3361 Fix SocketTest.TestRecvReset
The case SocketTest.TestRecvReset is not steady, and can cause
jenkins -1, and need rerun it. And I found using a fixed timeout
parameter is not good enough.
eg: Set timeout 1ms coredump happened.
Check failure stack trace: ***
Aborted at 1650445865 (unix time) try "date -d @1650445865" if you are
using GNU date ***
PC: @ 0x7fd63d0092e7 __GI_raise
SIGABRT (@0x198309) received by PID 1671945 (TID 0x7fd640cb7980) from
PID 1671945; stack trace: ***
@ 0x7fd63e8881d1 google::(anonymous namespace)::FailureSignalHandler()
@ 0x7fd63d390140 (unknown)
@ 0x7fd63d0092e7 __GI_raise
@ 0x7fd63d00a6c8 __GI_abort
@ 0x7fd63e878419 google::logging_fail()
@ 0x7fd63e87be9d google::LogMessage::Fail()
@ 0x7fd63e87daae google::LogMessage::SendToLog()
@ 0x7fd63e87ba20 google::LogMessage::Flush()
@ 0x7fd63e87e399 google::LogMessageFatal::~LogMessageFatal()
@ 0x21ff23 kudu::SocketTest::ConnectToListeningServer()
@ 0x21cc4a kudu::SocketTest::DoTestServerDisconnects()
@ 0x21b29c kudu::SocketTest_TestRecvReset_Test::TestBody()
@ 0x7fd63e219f2e testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x7fd63e20fa2b testing::Test::Run()
@ 0x7fd63e20fb95 testing::TestInfo::Run()
@ 0x7fd63e20fc85 testing::TestSuite::Run()
@ 0x7fd63e210144 testing::internal::UnitTestImpl::RunAllTests()
@ 0x7fd63e21a46e testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x7fd63e210340 testing::UnitTest::Run()
@ 0x7fd640e933c1 RUN_ALL_TESTS()
@ 0x7fd640e92316 main
@ 0x7fd63cff5ac5 __libc_start_main
@ 0x219029 (unknown)
Aborted (core dumped)
eg: Set timeout 50ms test failed.
Value of: s.message().ToString()
Expected: contains regular expression "recv error from
127.0.0.1:[0-9]+: Resource temporarily unavailable"
Actual: "recv error from unknown peer: Transport endpoint is not
connected" (of type std::string)
WARNING: Logging before InitGoogleLogging() is written to STDERR
Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
---
M src/kudu/util/net/socket-test.cc
1 file changed, 15 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/18431/4
--
To view, visit http://gerrit.cloudera.org:8080/18431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
Gerrit-Change-Number: 18431
Gerrit-PatchSet: 4
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18431 )
Change subject: [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18431/3/src/kudu/util/net/socket-test.cc
File src/kudu/util/net/socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/18431/3/src/kudu/util/net/socket-test.cc@127
PS3, Line 127: void DoTestServerDisconnects(bool accept, const std::string &message) {
> I guess eventually we want to use std::thread everywhere in Kudu code, so I
Done
http://gerrit.cloudera.org:8080/#/c/18431/3/src/kudu/util/net/socket-test.cc@136
PS3, Line 136: CHECK_OK(listener_.Accept(&sock, &new_addr
> What's the reason to have this extra wait interval? Please add a comment t
Removed
--
To view, visit http://gerrit.cloudera.org:8080/18431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
Gerrit-Change-Number: 18431
Gerrit-PatchSet: 4
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 26 Apr 2022 10:00:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18431 )
Change subject: [unit test] KUDU-3361 Fix SocketTest.TestRecvReset
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18431/3/src/kudu/util/net/socket-test.cc
File src/kudu/util/net/socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/18431/3/src/kudu/util/net/socket-test.cc@127
PS3, Line 127: void DoTestServerDisconnects(bool accept, const std::string &message) {
> Done
Done
--
To view, visit http://gerrit.cloudera.org:8080/18431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie85f36532510db53c8ac167f9d20689da0c76d33
Gerrit-Change-Number: 18431
Gerrit-PatchSet: 4
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 26 Apr 2022 10:00:37 +0000
Gerrit-HasComments: Yes