You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/12/02 22:40:37 UTC
[GitHub] [nifi] mattyb149 opened a new pull request #4704: NIFI-7906: Implemented RecordSetWriter support for ExecuteGraphQueryRecord
mattyb149 opened a new pull request #4704:
URL: https://github.com/apache/nifi/pull/4704
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
ExecuteGraphQueryRecord specifies a Failed Record Writer property that is meant to write out any records that fail during processing of the graph query. However the current implementation doesn't use it and instead sends the entire input flowfile to failure, and can result in a flowfile that doesn't get transferred (causing an exception). This PR refactors the processor to use the writer to write any failed records to the failure relationship.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #4704: NIFI-7906: Implemented RecordSetWriter support for ExecuteGraphQueryRecord
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4704:
URL: https://github.com/apache/nifi/pull/4704
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on a change in pull request #4704: NIFI-7906: Implemented RecordSetWriter support for ExecuteGraphQueryRecord
Posted by GitBox <gi...@apache.org>.
MikeThomsen commented on a change in pull request #4704:
URL: https://github.com/apache/nifi/pull/4704#discussion_r536841700
##########
File path: nifi-nar-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQueryRecord.java
##########
@@ -199,56 +200,70 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
.getValue()))
);
-
- boolean failed = false;
- long delta = 0;
+ long delta;
+ FlowFile failedRecords = session.create(input);
+ WriteResult failedWriteResult = null;
try (InputStream is = session.read(input);
RecordReader reader = recordReaderFactory.createRecordReader(input, is, getLogger());
+ OutputStream os = session.write(failedRecords);
+ RecordSetWriter failedWriter = recordSetWriterFactory.createWriter(getLogger(), reader.getSchema(), os, input.getAttributes())
) {
Record record;
-
long start = System.currentTimeMillis();
+ failedWriter.beginRecordSet();
while ((record = reader.nextRecord()) != null) {
FlowFile graph = session.create(input);
- List<Map<String,Object>> graphResponses = new ArrayList<>();
-
- Map<String, Object> dynamicPropertyMap = new HashMap<>();
- for (String entry : dynamic.keySet()) {
- if(!dynamicPropertyMap.containsKey(entry)) {
+ try {
+ Map<String, Object> dynamicPropertyMap = new HashMap<>();
+ for (String entry : dynamic.keySet()) {
+ if (!dynamicPropertyMap.containsKey(entry)) {
dynamicPropertyMap.put(entry, getRecordValue(record, dynamic.get(entry)));
}
- }
+ }
- dynamicPropertyMap.putAll(input.getAttributes());
- graphResponses.addAll(executeQuery(recordScript, dynamicPropertyMap));
+ dynamicPropertyMap.putAll(input.getAttributes());
+ List<Map<String, Object>> graphResponses = new ArrayList<>(executeQuery(recordScript, dynamicPropertyMap));
- OutputStream graphOutputStream = session.write(graph);
- String graphOutput = mapper.writerWithDefaultPrettyPrinter().writeValueAsString(graphResponses);
- graphOutputStream.write(graphOutput.getBytes(StandardCharsets.UTF_8));
- graphList.add(graph);
- graphOutputStream.close();
+ OutputStream graphOutputStream = session.write(graph);
+ String graphOutput = mapper.writerWithDefaultPrettyPrinter().writeValueAsString(graphResponses);
+ graphOutputStream.write(graphOutput.getBytes(StandardCharsets.UTF_8));
+ graphOutputStream.close();
+ session.transfer(graph, GRAPH);
+ } catch (Exception e) {
+ // write failed records to a flowfile destined for the failure relationship
Review comment:
It would be good to have a debug logger statement here so users can easily turn on logging for record failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org