You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/08/13 22:19:15 UTC
[kudu-CR] [WIP] [tools] KUDU-2461 Add election metrics to ksck
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10588
to look at the new patch set (#5).
Change subject: [WIP] [tools] KUDU-2461 Add election metrics to ksck
......................................................................
[WIP] [tools] KUDU-2461 Add election metrics to ksck
KUDU-2287 added two new metrics:
* failed_elections_since_stable_leader
* time_since_last_leader_heartbeat
This commit adds two ksck configuration options:
* failed_elections_warn_limit (default 3)
* millis_since_heartbeat_warn_limit (default 5000)
If any of them is reached, a warning is added to the ksck output:
Replica 39d3ec2c1f9541e18162a344645a4cdc of
e996c2436f3149eba8f7207bb6281a0d has not heard from the leader in 275991
ms and has called 33 failed election(s) since then.
Change-Id: I16fa6f32e6df7698365e908c7b48e63b0e52c745
---
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/metadata.proto
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_remote.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tablet_service.h
11 files changed, 147 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/10588/5
--
To view, visit http://gerrit.cloudera.org:8080/10588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I16fa6f32e6df7698365e908c7b48e63b0e52c745
Gerrit-Change-Number: 10588
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>