You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by NicoK <gi...@git.apache.org> on 2017/10/06 15:20:41 UTC

[GitHub] flink pull request #4783: [FLINK-7774][network] fix not clearing deserialize...

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4783

    [FLINK-7774][network] fix not clearing deserializers on closing an input

    ## What is the purpose of the change
    
    On cleanup of the `AbstractRecordReader`, `StreamInputProcessor`, and `StreamTwoInputProcessor`, the deserializers' current buffers are cleaned up but not their internal `spanningWrapper` and `nonSpanningWrapper` (via `RecordDeserializer#clear()`). This call should be added.
    
    ## Brief change log
    
    - also clean up the internal `RecordDeserializer` state during cleanup of input channels
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-7774

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4783.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4783
    
----
commit 341b3403d58337b87a8caffd87bc6a0f63292ea2
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-09-04T15:21:52Z

    [FLINK-7774][network] fix not clearing deserializers on closing an input

----


---

[GitHub] flink issue #4783: [FLINK-7774][network] fix not clearing deserializers on c...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4783
  
    merging.


---

[GitHub] flink issue #4783: [FLINK-7774][network] fix not clearing deserializers on c...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4783
  
    Looks good, +1 to merge this


---

[GitHub] flink pull request #4783: [FLINK-7774][network] fix not clearing deserialize...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4783


---