You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "flowy0 (via GitHub)" <gi...@apache.org> on 2024/04/08 13:30:37 UTC
[PR] [ZEPPELIN-6011] fix Dockerfile JAVA_HOME to openjdk11 [zeppelin]
flowy0 opened a new pull request, #4751:
URL: https://github.com/apache/zeppelin/pull/4751
### What is this PR for?
To fix the Dockerfile for Zeppelin Server for `branch-0.11`. The `JAVA_HOME` variable was set to Java 8, while `openjdk11` is being installed.
This issue is already fixed in the master branch.
### What type of PR is it?
Bug Fix
*Please leave your type of PR only*
### Todos
* [ ] - Fix JAVA_HOME variable in `scripts/docker/zeppelin-server/Dockerfile`
### What is the Jira issue?
[* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/](https://issues.apache.org/jira/browse/ZEPPELIN-6011)
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here
* Not too sure how to automate this testing as i'm new at this.
### Screenshots (if appropriate)
### Questions:
* Does the license files need to update?
* Is there breaking changes for older versions?
* Does this needs documentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6011] fix Dockerfile JAVA_HOME to openjdk11 [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer merged PR #4751:
URL: https://github.com/apache/zeppelin/pull/4751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6011] fix Dockerfile JAVA_HOME to openjdk11 [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #4751:
URL: https://github.com/apache/zeppelin/pull/4751#issuecomment-2042816202
FYI,
https://github.com/search?q=repo%3Aapache%2Fzeppelin%20JAVA_HOME&type=code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6011] fix Dockerfile JAVA_HOME to openjdk11 [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4751:
URL: https://github.com/apache/zeppelin/pull/4751#issuecomment-2042801355
> Helo, thank you for the contribution. Could you please make the same one for master branch?
Already fixed in master https://github.com/apache/zeppelin/commit/0f366d8a000cf313cce364b5a95dc84c1e600f90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6011] fix Dockerfile JAVA_HOME to openjdk11 [zeppelin]
Posted by "flowy0 (via GitHub)" <gi...@apache.org>.
flowy0 commented on PR #4751:
URL: https://github.com/apache/zeppelin/pull/4751#issuecomment-2042838607
> Wow! I was in a different place of
>
> https://github.com/apache/zeppelin/blob/fa6e3ee3b83aa5ffc070557780ec111386b8c951/scripts/docker/zeppelin/bin/Dockerfile#L27
>
> Could you please fix the line as well?
Seems like this file is installing and using JDK8?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6011] fix Dockerfile JAVA_HOME to openjdk11 [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #4751:
URL: https://github.com/apache/zeppelin/pull/4751#issuecomment-2042810784
Wow! I was in a different place of
https://github.com/apache/zeppelin/blob/fa6e3ee3b83aa5ffc070557780ec111386b8c951/scripts/docker/zeppelin/bin/Dockerfile#L27
Could you please fix the line as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6011] fix Dockerfile JAVA_HOME to openjdk11 [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #4751:
URL: https://github.com/apache/zeppelin/pull/4751#issuecomment-2042886318
Yes, this also should use java 11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6011] fix Dockerfile JAVA_HOME to openjdk11 [zeppelin]
Posted by "flowy0 (via GitHub)" <gi...@apache.org>.
flowy0 commented on PR #4751:
URL: https://github.com/apache/zeppelin/pull/4751#issuecomment-2043023104
> Yes, this also should use java 11
Alright, I'll create another PR then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6011] fix Dockerfile JAVA_HOME to openjdk11 [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #4751:
URL: https://github.com/apache/zeppelin/pull/4751#issuecomment-2042793475
Helo, thank you for the contribution. Could you please make the same one for master branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org