Re: [PR] [C++] do not hardcode Unix Makefiles generator [avro]

["martin-g (via GitHub)" <gi...@apache.org>]

martin-g commented on code in PR #2745:
URL: https://github.com/apache/avro/pull/2745#discussion_r1494180255


##########
lang/c++/build.sh:
##########
@@ -71,7 +71,6 @@ function do_dist() {
   fi
 }
 
-(mkdir -p build; cd build; cmake --version; cmake -G "Unix Makefiles" ..)

Review Comment:
   The `clean` target fails if another target that creates the `build/` folder is not executed first.
   ```
   avro/lang/c++ on  mkmkme/no-make [$?] via △ v3.22.1 
   ❯ ./build.sh clean
   Error: /home/martin/git/apache/avro/lang/c++/build is not a directory
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org