[GitHub] [flink] sunhaibotb commented on a change in pull request #8742: [FLINK-11879] Add validators for the uses of InputSelectable, BoundedOneInput and BoundedMultiInput

[GitBox <gi...@apache.org>]

sunhaibotb commented on a change in pull request #8742: [FLINK-11879] Add validators for the uses of InputSelectable, BoundedOneInput and BoundedMultiInput
URL: https://github.com/apache/flink/pull/8742#discussion_r300935767
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -337,6 +338,9 @@ public final void invoke() throws Exception {
 			operatorChain = new OperatorChain<>(this, recordWriters);
 			headOperator = operatorChain.getHeadOperator();
 
+			// check environment for selective reading
+			checkSelectiveReadingEnv();
 
 Review comment:
   If validated on the JM side, one way to determine whether a job contains selective reading operator is to mark it by adding a boolean field in `JobGraph` when generating JobGraph, and another way is to deserialize `StreamOperatorFactory` from `StreamConfig`. I don't think the second way is good, because JM currently does not need to deserialize `StreamConfig`, which will increase the time cost. Considering that the default value of `taskmanager.network.credit-model` is true, this check is a protective code and it does not normally trigger a check exception. In addition, `taskmanager.network.credit-model` is an option that is deprecated, and the validation will not be needed after it is removed. So I think it's easier to add validation here and to remove it in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services