You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/07/17 19:33:38 UTC

[Bug 120300] New: PreventHelpTips is not documented in com.sun.star.text.ViewSettings

https://issues.apache.org/ooo/show_bug.cgi?id=120300

          Priority: P3
            Bug ID: 120300
          Assignee: ooo-issues@incubator.apache.org
           Summary: PreventHelpTips is not documented in
                    com.sun.star.text.ViewSettings
          Severity: normal
        Issue Type: DEFECT
    Classification: Code
                OS: All
          Reporter: arielch@apache.org
          Hardware: All
            Status: CONFIRMED
           Version: AOO 3.4.0
         Component: code
           Product: api

Property "PreventHelpTips" is not documented in com.sun.star.text.ViewSettings


Sub Main
    Dim oDoc as Object
    Dim oController as Object
    oDoc = ThisComponent    
    oController = oDoc.getCurrentController()

    Dim oViewSettings as Object
    oViewSettings = oController.getViewSettings()

    Dim oPropInfo as Object
    oPropInfo = oViewSettings.getPropertySetInfo()

    If oPropInfo.hasPropertyByName("PreventHelpTips") Then
        'Toggle it
        Dim bPropVal as Boolean
        bPropVal = oViewSettings.getPropertyValue("PreventHelpTips")
        oViewSettings.setPropertyValue("PreventHelpTips", NOT bPropVal)
    End If    
End Sub

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120300] PreventHelpTips is not documented in com.sun.star.text.ViewSettings

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120300

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |AOO 4.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 120300] PreventHelpTips is not documented in com.sun.star.text.ViewSettings

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120300

--- Comment #2 from Ariel Constenla-Haile <ar...@apache.org> ---
(In reply to comment #1)
> While we are at it, it seems it would be better to rename it to
> "PreventContentTips".
> 
> When true, this property prevents Writer from displaying a help balloon when
> the mouse if over a text content on the edit window, see
> 
> void SwEditWin::RequestHelp(const HelpEvent &rEvt)
> main/sw/source/ui/docvw/edtwin2.cxx

In order to be consistent with the other ViewSettings, it is better to rename
it to "ShowContentTips". This is change is rather safe because:

a) it is hardly used in the source code (only one time)
b) this property is undocumented, so it's likely that there is no client code
using it

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120300] PreventHelpTips is not documented in com.sun.star.text.ViewSettings

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120300

--- Comment #4 from SVN Robot <sv...@dev.null.org> ---
"arielch" committed SVN revision 1363583 into trunk:
#i120300# - Add new property "ShowContentTips" in
com.sun.star.text.ViewSettings

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 120300] PreventHelpTips is not documented in com.sun.star.text.ViewSettings

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120300

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ooo-issues@incubator.apache
                   |                            |.org
           Assignee|ooo-issues@incubator.apache |arielch@apache.org
                   |.org                        |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 120300] PreventHelpTips is not documented in com.sun.star.text.ViewSettings

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120300

--- Comment #3 from Ariel Constenla-Haile <ar...@apache.org> ---
Created attachment 78673
  --> https://issues.apache.org/ooo/attachment.cgi?id=78673&action=edit
Patch to add ShowContentTips property to Writer's ViewSettings

The patch 
- renames PreventTips to ShowContentTips in
officecfg/registry/schema/org/openoffice/Office/Writer.xcs

- documents the property in the IDL definition
offapi/com/sun/star/text/ViewSettings.idl

- changes functions names, enums and constants to be consistent with the new
naming (binfilter, sw)

- adapts the code that uses PreventTips (sfx2)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120300] PreventHelpTips is not documented in com.sun.star.text.ViewSettings

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120300

--- Comment #1 from Ariel Constenla-Haile <ar...@apache.org> ---
While we are at it, it seems it would be better to rename it to
"PreventContentTips".

When true, this property prevents Writer from displaying a help balloon when
the mouse if over a text content on the edit window, see

void SwEditWin::RequestHelp(const HelpEvent &rEvt)
main/sw/source/ui/docvw/edtwin2.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120300] PreventHelpTips is not documented in com.sun.star.text.ViewSettings

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120300

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Ariel Constenla-Haile <ar...@apache.org> ---
Fixed in trunk

-- 
You are receiving this mail because:
You are on the CC list for the bug.